Giter Site home page Giter Site logo

Comments (3)

pensierinmusica avatar pensierinmusica commented on April 19, 2024

I get the same issue, not sure if the bug is in cookie-session or in connect-livereload. Besides this, it looks like cookie-sessions are generated only after some value is assigned to the session.

Not sure if it's intentional, I'd say it makes sense, although the documentation in readme.md states:

This module provides "guest" sessions, meaning any visitor will have a session, authenticated or not. If a session is new a Set-Cookie will be produced regardless of populating the session.

In particular the part saying "regardless of populating the session" is where I get a bit confused compared to the actual behavior.

Anyways, it'd be great if we could debug the connect-livereload problem first and then see if the two issues are actually related to each other, or completely separate.

from cookie-session.

KoryHerzinger avatar KoryHerzinger commented on April 19, 2024

For what it's worth, I ran into the same problem recently. It appears that using the connect-livereload middleware before using the session middleware is causing problems:

app.use(require('connect-livereload')());
...
app.use(cookieParser());
app.use(session({
    secret: 'SECRET',
    store: new RedisStore()
}));

By moving the connect-livereload middleware after the session middleware, sessions started working for me again:

app.use(cookieParser());
app.use(session({
    secret: 'SECRET',
    store: new RedisStore()
}));
...
app.use(require('connect-livereload')());

from cookie-session.

dougwilson avatar dougwilson commented on April 19, 2024

This is a bug with connect-livereload. Amny things like this module patches stuff like res.end, but livereload will ruin this: https://github.com/intesso/connect-livereload/blob/v0.4.0/index.js#L94-98

Live reload should not do that restore without being sure that the values it's overwriting is still it's own. Please file bugs at https://github.com/intesso/connect-livereload

from cookie-session.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.