Giter Site home page Giter Site logo

Comments (7)

Fishrock123 avatar Fishrock123 commented on March 28, 2024

This breaks anyone who is naively using any hard-coded references to the default cookie name.

For now, just use the name option.

from cookie-session.

dougwilson avatar dougwilson commented on March 28, 2024

This breaks anyone who is naively using any hard-coded references to the default cookie name.

Exactly. We should probably change it, but cannot for some time.

from cookie-session.

dougwilson avatar dougwilson commented on March 28, 2024

Perhaps we should just not even have this be a default? I think that would be the better option to make people choose their own cookie names, since that is basically an integral part of cookies.

from cookie-session.

Fishrock123 avatar Fishrock123 commented on March 28, 2024

Perhaps we should just not even have this be a default?

Yeah, that might be a good idea.
We should probably also error on RFC-invalid cookie names.

from cookie-session.

dougwilson avatar dougwilson commented on March 28, 2024

We should probably also error on RFC-invalid cookie names.

Yea. I looked at the RFC and it says the cookie name should be a token (which cannot have things like :).

from cookie-session.

anextro avatar anextro commented on March 28, 2024

Has this problem been solved.?

from cookie-session.

dougwilson avatar dougwilson commented on March 28, 2024

@anextro no, not until the next major release. You can always just use a different cookie name from the default for your app in the meantime.

from cookie-session.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.