"Access-Control-Allow-Origin" is not added to headers

[nahwinrajan]

"Access-Control-Allow-Origin" is not added to headers

[nahwinrajan]

Function - set origin to a function implementing some custom logic. The function takes the request origin as the first parameter and a callback (which expects the signature err [object], allow [bool]) as the second.

the readme file state the second callback's parameter is a boolean

[dougwilson]

This is not a bug, rather you accidentally made a mistake in your origin function. The second argument to callback needs to be the string of the origin to allow, but instead you are passing originsWhiteList[origin], which is actually the value true. Your function should be the following:

  origin: function(origin, callback) {
    callback(originsWhiteList[origin] ? null : 'Bad Request', origin);
  },

[dougwilson]

Weird, then not sure. Can you issue a PR that fixes the issue you are having?

[nahwinrajan]

I believe that only fault is at ReadMe.md file only,
the function actually expecting string of the allowed url (origin url, as you suggested)

[dougwilson]

So after spending the past week getting to know this module better to help maintain it--it turns out that both are correct. The second argument you give to the callback can actually be any valid value to the origin option (so, an array, a string, a boolean, etc.).