Giter Site home page Giter Site logo

Comments (2)

dougwilson avatar dougwilson commented on April 28, 2024 1

Your code calls app.use but next calls next() inside, so requests will never move to the next middleware. Your code can just be simplified to the following:

const cors = require('cors');

    let allowedOrigins = [];
    if (process.env.NODE_ENV === "development") {
        allowedOrigins = [
            "http://www.example.local", 
            "https://www.example.local",
        ];
    } else if (process.env.NODE_ENV === "staging") {
        allowedOrigins = [
            "http://staging.example.com", 
            "https://staging.example.com", 
        ];
    } else if (process.env.NODE_ENV === "production") {
        allowedOrigins = [
            "http://www.example.com", 
            "https://www.example.com",  
        ];
    }
app.use(cors({
        credentials: true,
        origin: allowedOrigins,
        "Access-Control-Allow-Headers": "Origin, X-Requested-With, Access-Control-Max-Age, Content-Type, Accept",
        "Access-Control-Allow-Methods": "GET, POST, OPTIONS, DELETE, PUT",
}));

from cors.

maki3000 avatar maki3000 commented on April 28, 2024

Thank you very much @dougwilson

This is working splendid now. BTW, I forgot to use the right options for allowedHeaders and methods. So beneath to upper part of the last snippet, where I prepare allowedOrigins for different envs, I use now the cors module like this:

app.use(cors({
    credentials: true,
    origin: allowedOrigins,
    allowedHeaders: "Origin, X-Requested-With, Access-Control-Max-Age, Content-Type, Accept, x-cron-token, x-path",
    methods: "GET, POST, OPTIONS, DELETE, PUT",
}));

from cors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.