add OPTIONS to default methods

[expressjs]

add OPTIONS to default methods

[troygoode]

@tkellen OPTIONS requests works by default if you "install" the cors module globally within your express application (i.e. app.use(cors());). If you're using cors on a route-by-route basis (app.post('/foo', cors(), ...);) then the cors module doesn't even receive OPTIONS requests (only POST requests in my provided example), so you need to do a bit more work.

[troygoode]

@tkellen just as an FYI, this line is what is supposed to enable the effect I described above:

cors/lib/index.js

Line 156 in ddc7d03

if (method === 'OPTIONS') {

[jamesplease]

Related in the docs: https://github.com/expressjs/cors#enabling-cors-pre-flight

[tkellen]

Yup, I see that. I'd love to know why that isn't the default behavior in the first place.

[tkellen]

That's not true. I can provide a reproduction if you re-open this.

[tkellen]

cc @bobholt

[troygoode]

I'd love to see it @tkellen