Comments (5)
This was actually implemented specifically so that data
events wouldn't go missing, if someone was using the async version of the cors options setup. In older versions of node.js (prior to 0.10) .pause()
and .resume()
were necessary to prevent loss of data
events of a stream between ticks.
Are you still running into this problem?
from cors.
I'm running into this problem as well
I'm using this module for static/sync cors headers before proxying to a couchDB url but it still consumes my request. I can understand the pause() calls, but I have a harder time understanding why resume() is called.
Anyway, this is not the recommended way of doing things in node >=0.10. pause() and resume() cause the request to switch to old streams mode and thus consuming the stream before I get a chance to use it. Most importantly, it causes this fix (nodejs/node-v0.x-archive#4969) to be unefficient.
Since i'm using request to do one-line proxying, I have some lines like this down the middleware chain.
req.pipe(request(url)).pipe(res)
since req
is already consumed (and has already emitted 'end'
), it causes my service to hang on this particular request. (yes i'm piping req
even though it's a GET request, but this way request
can use the clients cache-control headers and pass them through).
I can see several fixes for this.
- don't call
pause()/resume()
when cors is in sync mode - don't call
pause()/resume()
at all, since it's hardly cors responsibility to worry about the body of a request - only use streams2 API.
my fix for my own problem for now is to remove cors altogether and set my static header myself =)
from cors.
Let me look into this.
from cors.
I've removed pause
and resume
and specified 0.10
as the minimum required version of node.js.
from cors.
Thanks!
Le 5 juil. 2014 20:48, "Troy Goode" [email protected] a Γ©crit :
I've removed pause and resume and specified 0.10 as the minimum required
version of node.js.β
Reply to this email directly or view it on GitHub
#6 (comment).
from cors.
Related Issues (20)
- [Feature request] A more powerful custom origin calculation method depending on other headers HOT 6
- No Configuration Options for Access-Control-Allow-Private-Network HOT 1
- CORS Error only on Mac HOT 2
- Cors origin RegExp issues HOT 10
- Option preflightContinue not working with origin function
- Array - set origin -Not working HOT 3
- Incorrect response when option origin is true and requestOrigin is undefined HOT 2
- "origin" is undefined when requests are received from the same server AND when malicious requests are sent from a program HOT 1
- Undefined origin should be treated as not allowed - discusson HOT 4
- Configure Allowed Headers as Array of RegExp
- DEMO is broken HOT 1
- Invalid Vary header in Access-Control-Allow-Headers HOT 2
- `OPTIONS` request handler missing `Allow` header HOT 13
- cors is hanging HOT 2
- CORS error when fonts
- Add support for having specified domain instead of wildcard HOT 3
- Request: callback for failed CORS HOT 5
- Cors error when connecting through ssh tunnel HOT 1
- I have random 'Access-Control-Allow-Origin' errors, even if i set origin: '*', is my usage correct ? HOT 3
- Add ability to omit `Vary: Origin` header HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cors.