Giter Site home page Giter Site logo

Comments (9)

dougwilson avatar dougwilson commented on March 29, 2024

Hmm, not sure. What version of Node.js is the error occurring on? Any way I can reproduce? The versions running on Travis CI are not having the issue.

from csurf.

nathanielescribano avatar nathanielescribano commented on March 29, 2024

I'm using 0.12.1. npm - 2.5.1 whats interesting is if i open up a node console and run
c.createHash('sha1').update("salt").update("-").digest("base64")
it works fine. But when it runs within my app, i get the issue described above.

from csurf.

dougwilson avatar dougwilson commented on March 29, 2024

Gotcha. I'm not able to reproduce on 0.12.1. Anyway you can help me? What about can you paste a complete file I can paste on my system and run that will throw that error?

from csurf.

nathanielescribano avatar nathanielescribano commented on March 29, 2024

Figured out the issue.
I was using https://github.com/jas-/connect-redis-crypto/blob/master/lib/connect-redis.js
This file has a line crypto.DEFAULT_ENCODING = 'hex' . That leaves the DEFAULT_ENCODING to 'hex' so when csurf calls .update('-') it crashes.

in a node console doing

crypto.DEFAULT_ENCODING = "hex" 
crypto.createHash('sha1').update('salt').update('-')

gives me the error I mentioned earlier.

seems like one shouldn't change the DEFAULT_ENCODING as it might affect other modules, but
should csurf be explicit about what encoding needs to be used?
Any general thoughts on this?

from csurf.

nathanielescribano avatar nathanielescribano commented on March 29, 2024

Thanks a lot for being so responsive by the way 💃

from csurf.

dougwilson avatar dougwilson commented on March 29, 2024

Ah ha! Yes, I agree on both points: no, a module should not be doing that and yes, we should be explicit, especially since it won't hurt anything. Feel free to submit a PR, otherwise I'll get around to it eventually :)

from csurf.

dougwilson avatar dougwilson commented on March 29, 2024

Ok, I'm going to add the explicitness now :) I also noticed that the above crypto is not actually a part of this module, but rather a part of a dependency, so I'll be updating the csrf module and closing this issue :)

from csurf.

dougwilson avatar dougwilson commented on March 29, 2024

Ok, version 1.8.1 will be published shortly with the fix :)

from csurf.

nathanielescribano avatar nathanielescribano commented on March 29, 2024

awesome! Thanks!!

from csurf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.