Giter Site home page Giter Site logo

discussions's People

Contributors

dougwilson avatar jonchurch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

discussions's Issues

Express TC meeting 01-11-2017

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Jan 11, 2017 - 23:30 UTC

Where

YouTube Live

  • Viewers: TBD
  • Participants: TBD

Agenda

Express TC Meeting 10-05-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Oct 5, 2016 - 23:30 UTC

Where

YouTube Live

Viewers: https://www.youtube.com/watch?v=KhIxUWh9fCU

Participants: https://hangouts.google.com/hangouts/_/ytl/kpFzF4WZWZpZc89pd4Anj-Ffu-6vJoCkdquGKlveQ3M=?eid=118089942299398580717&hl=en_US&authuser=0

Agenda

  • Discuss README translation - see #38
  • Discuss X-Powered-By - see #39
  • Discuss routing with host name - see expressjs/express#3088
  • Other business

Express TC Meeting - 2016-06-15

Who

Invited:

When

June 15th, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYePqCMX_ZRSR2Wv6ejyNIelwomKoju-fQi4GJJLRGUGO-reew?hl=en&authuser=0
Link for Observers: https://plus.google.com/events/cj8fjj62jbudjigf4oqqrbtet20?hl=en

Agenda

Express TC Meeting - 2016-03-01

Who

Invited:

When

March 1st, 2016 - 6:30pm Eastern (3:30pm Pacific)

Where

Google Hangouts:

Link for Participants: https://plus.google.com/hangouts/_/hoaevent/AP36tYezJItkc6q3Z1E9wEw3Sp8uoxus30-oBznf8_hyZRAL3d6UnQ?hl=en&authuser=0

Link for Observers: https://plus.google.com/events/c1t25h6931767e8s357iuo2jclk

Minutes

Google Doc: https://docs.google.com/document/d/1KZPRK4XnKhpVqFaQ_BjJmDxFHEm8N1xaEUfQvKLtG0E/edit
(please request access for editing)

Agenda

Express TC Meeting - 2016-05-04

Who

Invited:

When

May 4th, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://plus.google.com/hangouts/_/hoaevent/AP36tYf6VoNWFE34DYslhezTG8_72UHVO-NH9OCsDSKgOE2GNpZ33A?hl=en&authuser=0

Link for Observers: https://plus.google.com/events/c0sncerf8uil4l9kmlluoopq7us

Agenda

  • @expressjs Twitter handle

Express TC Meeting 08-24-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Aug 24, 2016 - 23:30 UTC

Where

Google Hangouts

Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYcp3RS0PQ9vuVlZYbMsIaL_yxXBzV5GKhbz1pceJO3yd2Lg_A?hl=en&authuser=0

Observers & Public: https://plus.google.com/events/c8ken3u1ugreq013do22tkl8kgk?hl=en

Agenda

Videos of Node.js talks by Express TC members

In case anyone is interested... from Node Interactive North America 2016:

Should we put these links (or embed the videos) somewhere on the website? Doug's is most relevant since it's specific to Express; Rand's is not specific to Express, though it does use expressjs.com as an example in a few places.

Express TC Meeting 09-21-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Sep 21, 2016 - 23:30 UTC

Where

YouTube Live

Participants: https://hangouts.google.com/hangouts/_/ytl/dEcq8Gmb685ipoHdQphac7XvLIvrLIga5wDFyh79P9M=?eid=118089942299398580717&hl=en_US&authuser=0

Observers & Public: https://www.youtube.com/watch?v=GFwJCd_PSsY

Agenda

  • Proposed README guidelines (#33) - Adopt if we have quorum (Rand
  • Docs for hbs module ? (Rand)
  • Other business

Express, HTTP/2 and Node.js Core

Hello @expressjs/express-tc!

I am currently heading up an effort to explore whether and how to implement HTTP/2 support directly in Node.js core. The question of If we should do this is still open. To help answer that question, as well as determine the best course forward should we decide to move ahead, I would love to get input from each of you with regards to what would be the best approach from the Express point of view.

Refs: nodejs/CTC#6

Using standard code style

This is a new discussion to live by itself stemmed from the comment at #14 (comment)

The idea is to apply eslint to our repos to help guide contributors and make it less confusing on what style to use. @LinusU suggested "standard" (http://standardjs.com/) and the style, and of course, I don't think everyone will agree with all aspects of the style, but after a lot of research, I tend to agree a vote for "standard" sounds fine to me. I found the following arguments for using standard:

  1. It's a set of rules with the philosophy of "no configuration", which means we shouldn't debate about any code styling after adopting it, which wastes time.
  2. When standard makes major changes, they pull down all repos using the standard style and run the liter against them to see what fails. This sounds good since it should mean we rarely will have an upgrade where we have to fix a bunch of over code to the new style :)

@LinusU please share any thoughts you have as well.

I have already converted a bunch of jshttp organization repos to this style, at least for the repos that were pretty much literally this style before, so there wasn't any real conversion anyway.

migrate hbs module to expressjs org

Email from @defunctzombie :

I would like to propose moving the hbs module (https://github.com/donpark/hbs) to the expressjs organization.

This will allow the project to get more eyeballs for issues (I don't have the same amount of time to maintain it as before) and also make it easier to manage the administrative tasks of the project (webhooks, etc). Github limits what type of admin powers you can grant to projects under a user account and as such it is harder to bring on new contributors and change settings without involving the account holder.

Don (original hbs creator and current user account holder) is ok with the migration and I believe it will benefit the module going forward so that it doesn't stagnate.

How would we proceed with moving it?

cheers,
~Roman

TC Meeting for 7/8/2016? Also, Minutes Doc?

Was wondering if there was a TC meeting for 7/8/2016? I didn't find an issue for that date.

Also, was wondering if it would be possible to have the minutes in a doc (e.g. google doc) to have something to quickly scan over, in lieu of watching the recording--which we'd still keep.

Express TC Meeting 09-07-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Sep 7, 2016 - 23:30 UTC

Where

Google Hangouts

Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYeHGh-oapOWXvateGP86YEvhQn97hvJGc8azZN3D3Rzlu_Y7w?hl=en&authuser=0

Observers & Public: https://plus.google.com/events/clg06cvasareslfpfsqjl5v1f74?hl=en

Agenda

Express TC meeting 11-02-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Nov 2, 2016 - 23:30 UTC

Where

YouTube Live

Agenda

Express TC meeting 2016-07-13 [canceled]

I'm just adding this since Doug hasn't done so yet....

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

July 13, 2016 - 23:30 UTC

Where

Google Hangouts: TBD

Link for Participants: TBD

Agenda

  • I added a para. about TC in two places on the website.
  • Adding list of TC members to website expressjs/expressjs.com#673
  • CloudFlare?
  • Other

Translated Readmes

Would like to raise something that I ran into today. Multer got a pull request with a translation of the readme into Chinese. I think this is great, but I don't have any good ideas for making sure that the translation is kept up to date. Maybe this is a non-issue though, would love some input from some other maintainers. Thanks ❤️

Pull request: expressjs/multer#400

Proposal to create more distinctive branding and logo

@RoyalRajdeep proposed in expressjs/expressjs.com#684 (comment)

Each Library and Framework I use, Have their own Branding, Iconic Logos, and Color theme, But Express is still not having any specific color theme, Iconic brand Logo. We are just having a simple b/w color themed website and a very simple logo type.

If Express Js community have the same thought , then I go ahead for this part to

  1. Suggest a new color theme for all Express Js related stuff. (Like NodeJS has Green+Grey, and they use the same Color Combination on all their stuff, Angular has Pink+White.)
  2. Design a new logo for express, based on our community suggestions.

This would be something that the @expressjs/express-tc would need to approve and perhaps discuss, so that's why I created this issue.

For the Website Part I will made a proposal soon.

@RoyalRajdeep please open a separate issue for any other proposal.

Express TC Meeting - 2016-07-27

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

July 27, 2016 - 23:30 UTC

Where

Google Hangouts: https://hangouts.google.com/hangouts/_/crftuxkaczemjnctenrp75f67ue?hl=en&authuser=0

Link for Participants: TBD

Agenda

  • Review use of CloudFlare for caching on expressjs.com.
  • #25 (?)
  • Revisit TC meeting time / frequency
  • Other

Express logo and favicon

As per the last TC meeting (#6) and the issue reported at expressjs/expressjs.com#607, we want a logo and a favicon for Express.

Here are the initial two proposals. The font used in the logo is "Helvetica Bold".

  1. "Ex" on a white background
    512-white
    256-white
    128-white
  2. "Ex" on a yellow background (themed after the popular "yellow JS logo")

512-yellow
256-yellow
128-yellow

The favicon will be derived from the logo.

Feedback welcome 😀

TypeScript Definitions

References: expressjs/express#2818, typings/typings#322, microsoft/TypeScript#7546.

Summary: For Express 5.x, support TypeScript by packaging definitions with the project. This is used by TypeScript automatically when you add typings to the package.json. As part of the effort, there needs to be a good CI step and process in place. As the author of @typings, I have plenty of background on solving the issue, but it should be as straight-forward as possible for everyone to be involved.

An initial PR demonstrating TypeScript definitions is available at pillarjs/path-to-regexp#72 and awaiting some review. Integration with CI will be an ongoing topic, the best process is having TypeScript test files which will do type checking and runtime checking. However, the linked issue above is one approach that can also work (comparing what TypeScript knows about the .js package and our hand written .d.ts file).

I'm opening this issue to give heads up and hopefully collaborate on the final solution for Express.js 5.x.

How do we feel about X-Powered-By?

After reading thru the security best practices today I realised that it puts quite a lot of focus on removing the X-Powered-By header. Seeing this my first thought was that "We should remove that header from Express 5, why be insecure out of-the-box". But upon reading further I found expressjs/express#2813 (comment) by @dougwilson, and I now think that we should instead remove the recommendation.

Sending mixed signals isn't good for our users, I think that we should either remove the header altogether, or remove any recommendations to remove it. Personally I'm leaning towards removing the recommendation to remove it from the security best practices page, but I would support moving in either direction.

What do you guys think?

Express TC Meeting 01-25-2017 [canceled]

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Jan 25, 2017 - 23:30 UTC

Where

YouTube Live

  • Viewers: TBD
  • Participants: TBD

Agenda

  • Discuss PR to doc overriding sugar methods: expressjs/expressjs.com#763
  • README guidelines per #33. Is this OK? Can we add these to our doc/contribution guidelines?
  • Other issue clean-up (can these be closed?):

Browser-support for jshttp (and maybe other) modules

from jshttp/content-type#7 (comment) and from the TC meeting w/ @wesleytodd

my thoughts:

  • UMD code should never be committed to GitHub (except as releases, maybe). UMD code should be built with a prepublish step.
  • there must be tests for browsers. a discussion of alternatives would be welcomed.
    • we only support browsers we test
    • phantomjs is acceptable as a first step, but it's not a browser, so we can't claim browser support
    • saucelabs is not very reliable, so i prefer not to use it
    • i hate selenium and i don't think it's relevant
    • substack's service is deprecated, which would've been nice and easy

my questions:

  • if you do not use webpack/browserify/npm/etc, how would you be consuming these?
  • would you consume UMD builds with GitHub releases?
  • do we want to support bower? (please no)
  • do we want to include all the dependencies in the UMD builds? this would be necessary for <script> tag users, but not bower users
  • do we want to run our code through babel? this will allow including polyfills and/or
  • what type of support are you looking for in browsers other than browserify module + tests -> running in the browser? i'm sure there are some edge cases, maybe polyfills like setImmediate() support.
  • would we want to push updates to CDNs like CDNJS?
  • how much effort do we want to put into these modules so that they aren't bloated for the browser?
    • for example, loading mime-db in the browser might be excessively large

going forward, i'd like to build a sample repo for standardizing all modules including (most of which is already pretty standardized thanks to @dougwilson):

  • readme (AND BADGES :D)
  • package.json
  • linting
  • node.js tests
  • browser tests

if we all agree on it, i don't mind making the PRs for a lot of the modules to make them all consistent

Express TC Meeting - 2016-06-01

Who

Invited:

When

June 1st, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYdSYgPMVaxBzT8rvCRVUNbke-iR1E5GveNBKwr89aZ_NErSqA?hl=en&authuser=0
Link for Observers: https://plus.google.com/events/cpb1lfkg9gkp8t9c9hvmnj30ma8

Agenda

YouTube channel

Currently all the TC meetings have been automatically uploaded into my own, personal YouTube account. I don't really care, but if people want to subscribe to the channel to watch new meeting, that is kind of weird. I created a separate YouTube channel a while ago, but just now finished moving all the videos: https://www.youtube.com/channel/UCYjxjAeH6TRik9Iwy5nXw7g

Express TC Meeting - 2016-05-18

Who

Invited:

When

May 18th, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYft9l2IfTLaipb-EUKkjVbZ0hILIuTmQ7IZwphrDbJXwSI71g?hl=en&authuser=0

Link for Observers: https://plus.google.com/events/cglonce2k9r7ljqqd58ovqmofn4?hl=en

Agenda

Express TC Meeting - 2016-03-23

Who

Invited:

When

March 23th, 2016 - 23:30 UTC (2016-03-23T23:30:00-0000; http://www.wolframalpha.com/input/?x=0&y=0&i=2016-03-23T23:30:00-0000+in+local+time)

Where

Google Hangouts:

Link for Participants: https://plus.google.com/hangouts/_/hoaevent/AP36tYfXMbG6d5y_pLRU6u-MOx3naD1gMFT2mdQFnRwgLTEgGM-OSQ?hl=en&authuser=0

Link for Observers: https://plus.google.com/events/cq1vt2vfc7vfcfo0de4brj9sjuo

Minutes

Google Doc: TBD

Agenda

  • Express Governance document
  • Express favicon/logo?
  • Express PR review
  • AppVeyor on generator

Express TC Meeting 2016-08-10

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Aug 10, 2016 - 23:30 UTC

Where

Google Hangouts: https://hangouts.google.com/hangouts/_/crftuxkaczemjnctenrp75f67ue?hl=en&authuser=0

Agenda

We need to discuss issues that were not resolved from last meeting, plus some new ones.

  • Review use of CloudFlare for caching on expressjs.com. Do we need it? Can NF take ownership?
  • #25
  • #27
  • #30
  • Tagging of 5.0 alpha per expressjs/express#3041
  • Discuss working on examples and/or moving examples out of core express repo into separate repo per expressjs/express#2923
  • Other

Confusing module on npm "express5"

I just was made aware of a module that has been published to npm a while ago with a confusing name: https://www.npmjs.com/package/express5

It looks like a user published the first alpha of 5.0 under the package name express5, which may likely be confusing to users. I'm not sure if we need to do anything or not, which is why I'm posting here.

The weird part is that it was published earlier this year, yet the second 5.0 alpha was out mid last year, so it doesn't seem like whoever that is is even trying to keep it up-to-date.

There is apparently an express3 and express4 package as well. ¯\_(ツ)_/¯

/cc @expressjs/express-tc @mikeal @jasnell

Express TC meeting 11-16-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Nov 16, 2016 - 23:30 UTC

Where

YouTube Live

Agenda

TBD

Express TC Meeting - 2016-06-29

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

June 29th, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://hangouts.google.com/hangouts/_/hoaevent/AP36tYcQjyd4_YGVC2CEg8sOjLN-dI3kazwL-rGAUeCxiR1IkhamNA?hl=en&authuser=0
Link for Observers: https://plus.google.com/events/ci581faosms7mup82p8h660l134?hl=en

Agenda

Move in multiparty

This is an issue to discuss if we want to move the multiparty module into the Express.js TC (probably under the pillarjs organization). I know I personally use it a lot, and have had a bunch of work go in there, but want to get how people feel about this. The module is currently offered to me if I would like to move it, and I feel like, if anywhere, Express.js would be a fine home for it.

Share the load doug!

thanks for all your work @dougwilson. i haven't been really involved in express for a while, but i'd still like to help. let me know how i or anyone else can help:

  • bump dependencies
  • convert to standard
  • documentation

etc.

i know you are particular on how you do things, so it would be great if you wrote it down :) i'll be sure not to publish myself so i don't mess it up ;)

Express TC Meeting 10-19-2016

Who

The entire community is welcome to tune in and observe the meeting live at the time below. The following people are listed here as explicit invitees to get an email notification about the upcoming meeting:

Invited:

When

Oct 19, 2016 - 23:30 UTC

Where

YouTube Live

Agenda

TBD.

Express TC Meeting - 2016-04-20

Who

Invited:

When

April 20th, 2016 - 23:30 UTC

Where

Google Hangouts:

Link for Participants: https://plus.google.com/hangouts/_/hoaevent/AP36tYdM_bgNKc1pXakhc8lqt_VHGS1Jea6WPR2irly_T-JSZAmY0g?hl=en&authuser=0

Link for Observers: https://plus.google.com/events/c42doafcrpf6pta39jskgrho7t4

Agenda

  • Node.js 6.0 release & compatibility

expressjs.com transfer progress

Tomorrow (Friday March 18th) I'll be looking into what steps are necessary to get the domain repo transferred. I'm not yet certain if there are any gotchas with regards to moving a repo with an associated Apex domain. I want to make sure that there are no hiccups in the site hosting before actually moving the repository.

I will use this issue to update on the progress.

/cc @expressjs/express-tc

link redirect after IP address change

Hi,
I'm running node server on some IP say 192.168.xx.xx
I have a module in my application where i can change the IP address.
Now when i change the IP to say 192.168.yy.yy, then i wait for 30 sec for the change to take effect & redirect the link to 192.168.yy.yy it doesn't happen.

Can anyone say where the problem lies?

No TC meeting on 12/28/2016

Due to the holidays, there won't be a TC meeting today. Next meeting will be on 11 Jan 2017.

Happy holidays, all! :-D

Should we keep the object prototype in req.body and similar fields

This question and similar comes up now and again: expressjs/multer#318

I'm not really sure what to do, maybe we could discuss this on the next TC meeting.

On the one hand

Consider what would happen if the client sent hasOwnProperty=nope or hasOwnProperty[call]=. This would break any script trying to use req.body.hasOwnProperty(_), and having client data break server code is never good.

On the other hand we get a few request from time to time and often they are using some utility library that breaks.

I think the main point would be to be consistent throughout our packages. It seems like most packages parses the body with the prototype intact.

While I can respect the cautiousness taken in the design, I believe this is one time where it's better to be consistent as a community, regardless of whether that is right or wrong. Currently, all of bodyparser's parsers spit out an Object object:

Current Express.js Website

This was brought up during this weeks weekly discussion, but contributing to the current Express.js website is difficult. Some reasons around that difficulty is because the Markdown is not actually pure Markdown and the build toolchain is hard to use.

I'd like to take some time to open a PR that'll refactor the website into a Markdown only workflow with a JavaScript-based build step. This would fix previewing contributions inside of GitHub, and all Windows users to contribute easier.

Any objections, or concerns, I should be aware of?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.