Giter Site home page Giter Site logo

Comments (7)

jordonias avatar jordonias commented on April 25, 2024

Your error handler should be after the routes. Also fails() is not defined, I think you're looking to use next() but it should be one of the arguments like function(req, res, next).

var express = require('express');
var errorHandler = require('errorhandler');

var app = express();

app.get('/', function(req, res, next) {
  return next(new Error('some error'));
});

app.use(errorHandler());

app.listen(3000);

It will also work if an error is thrown like:

var express = require('express');
var errorHandler = require('errorhandler');

var app = express();

app.get('/', function(req, res, next) {
  throw new Error('some error');
});

app.use(errorHandler());

app.listen(3000);

You'll want to review some of the api documentation, specifically:
http://expressjs.com/en/guide/using-middleware.html
http://expressjs.com/en/guide/error-handling.html

from errorhandler.

Knighton910 avatar Knighton910 commented on April 25, 2024

Yeah @rahmatawaludin, like @jordonias said, you always wanna define errors after you're routes.
And @jordonias i think that would be really cool, as discussed on gitter to do a pull request with more error handling examples. 👍

from errorhandler.

jordonias avatar jordonias commented on April 25, 2024

At a bare minimum there should be a link in README.md to the error-handling guide in the expressjs.com docs.

from errorhandler.

Knighton910 avatar Knighton910 commented on April 25, 2024

True 💯

Are you gonna make that pull request, or shall I?

from errorhandler.

jordonias avatar jordonias commented on April 25, 2024

You can start one if you'd like. I won't have time until later.

from errorhandler.

Knighton910 avatar Knighton910 commented on April 25, 2024

Yea, me as well, i'll have it in the pull request queue tonight.

from errorhandler.

dougwilson avatar dougwilson commented on April 25, 2024

I'm going to close this issue since the question was ultimately answered :)

from errorhandler.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.