Giter Site home page Giter Site logo

Supporting PUT requests? about multer HOT 11 CLOSED

expressjs avatar expressjs commented on April 25, 2024
Supporting PUT requests?

from multer.

Comments (11)

nfroidure avatar nfroidure commented on April 25, 2024

👍

from multer.

gplancke avatar gplancke commented on April 25, 2024

👍

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

Thanks for bringing it to notice and fixing it guys!

from multer.

ItalyPaleAle avatar ItalyPaleAle commented on April 25, 2024

Thanks for the patch, but I'm not sure this is completely fixed!
Indeed, this keeps supporting only multipart/form-data encoded requests. PUT requests instead often have in the body just te contents!

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

I had originally intended Multer to handle ONLY multipart POST data, as there was no middleware to handle this specific data. Issue #17 also needs to be addressed. It's time to revise Multer.

from multer.

ItalyPaleAle avatar ItalyPaleAle commented on April 25, 2024

Now that Express 4 is out, I think you should consider that. Issue #17 is one thing, but I would also add support for XML and JSON requests too, at this point.
Would it be ok with you if I investigated a patch? I may have some spare time mid next week, but no promises at all.

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

Feel free to work on a patch. However, the current most important task is
writing tests, it will help add new features and bug fixes without having
to fear regression issues. I am a little occupied, so not able to do much.

On Mon, May 5, 2014 at 3:48 AM, Alessandro [email protected] wrote:

Now that Express 4 is out, I think you should consider that. Issue #17https://github.com/expressjs/multer/issues/17is one thing, but I would also add support for XML and JSON requests too,
at this point.
Would it be ok with you if I investigated a patch? I may have some spare
time mid next week, but no promises at all.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-42147430
.

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

@EgoAleSum did you get a chance to work on it?

from multer.

ItalyPaleAle avatar ItalyPaleAle commented on April 25, 2024

Not yet, sorry

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

No problem.

from multer.

hacksparrow avatar hacksparrow commented on April 25, 2024

It does now.

from multer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.