Comments (13)
Yea, I can add that. Any particular reason you need it (just trying to justify feature bloat is all)?
from response-time.
Actually, nevermind. By default http response timings are in seconds. So the practice of adding 'ms' is actually better when it's not seconds.
from response-time.
OTOH dropbox doesn't include ms: https://www.dropbox.com/ x-server-response-time:141
from response-time.
Well, I could potentially allow configuration for the unit you want it in + if you want the units appended. Would that be something you want?
from response-time.
OTOH dropbox doesn't include ms: https://www.dropbox.com/ x-server-response-time:141
That sounds like a good enough case to me. Any thoughts on my latest comment as well?
from response-time.
Changing the unit isn't an issue for us. When response times are in the seconds, that's a problem! :-)
from response-time.
haha, sounds good :) I should have a new release for you tonight (US time).
from response-time.
Cool, thanks!
from response-time.
Let me know what you think of the implementation on master
.
from response-time.
I would maybe allow suffix to be a boolean or string? If string, use that as suffix (eg. millis instead of ms)?
from response-time.
Yea, I thought about that, but didn't want to preclude the future possibility to adjust the SI unit of the output or something. Basically I was trying to be conservative on that front, IDK :)
from response-time.
Haha ok cool. In that case, looks great.
from response-time.
Alrighty, published as 2.2.0
from response-time.
Related Issues (11)
- response-time does not contain data about url of request. HOT 1
- Expose X-Response-Time header by default HOT 2
- Different Response Times HOT 3
- Typescript Support HOT 4
- Option to make use of Server Timing header HOT 2
- Add support for request-received middleware HOT 4
- Warning on build for use of eval
- Rename digits to decimals HOT 1
- [RFC] timing only mode HOT 3
- Injecting response times into view templates HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from response-time.