Giter Site home page Giter Site logo

Comments (13)

dougwilson avatar dougwilson commented on April 25, 2024

Yea, I can add that. Any particular reason you need it (just trying to justify feature bloat is all)?

from response-time.

analytically avatar analytically commented on April 25, 2024

Actually, nevermind. By default http response timings are in seconds. So the practice of adding 'ms' is actually better when it's not seconds.

from response-time.

analytically avatar analytically commented on April 25, 2024

OTOH dropbox doesn't include ms: https://www.dropbox.com/ x-server-response-time:141

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

Well, I could potentially allow configuration for the unit you want it in + if you want the units appended. Would that be something you want?

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

OTOH dropbox doesn't include ms: https://www.dropbox.com/ x-server-response-time:141

That sounds like a good enough case to me. Any thoughts on my latest comment as well?

from response-time.

analytically avatar analytically commented on April 25, 2024

Changing the unit isn't an issue for us. When response times are in the seconds, that's a problem! :-)

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

haha, sounds good :) I should have a new release for you tonight (US time).

from response-time.

analytically avatar analytically commented on April 25, 2024

Cool, thanks!

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

Let me know what you think of the implementation on master.

from response-time.

analytically avatar analytically commented on April 25, 2024

I would maybe allow suffix to be a boolean or string? If string, use that as suffix (eg. millis instead of ms)?

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

Yea, I thought about that, but didn't want to preclude the future possibility to adjust the SI unit of the output or something. Basically I was trying to be conservative on that front, IDK :)

from response-time.

analytically avatar analytically commented on April 25, 2024

Haha ok cool. In that case, looks great.

from response-time.

dougwilson avatar dougwilson commented on April 25, 2024

Alrighty, published as 2.2.0

from response-time.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.