Giter Site home page Giter Site logo

Comments (4)

JosiahParry avatar JosiahParry commented on June 5, 2024 1

The current use case is filling a pre-allocated vector. I have a serde struct that I am trying to convert into a data-frame. Doing so is never going to be easy! But being able to use as_type_slice_mut() here helps greatly.

 let val = v.as_i64();
    let rint = match val {
        Some(i) => Rint::from(i as i32),
        None => Rint::na(),
    };
    let col: &mut [Rint] = col.as_typed_slice_mut().unwrap();
    col[i] = rint;

from extendr.

JosiahParry avatar JosiahParry commented on June 5, 2024 1

Alternatively, to solve this particular challenge, we could amend the rust's r-vector types with the following (done in gen_vector_wrapper_impl-macro)

        impl $type {
            #[doc = "Returns a slice of the underlying data"]
            pub fn as_slice(&self) -> &[$scalar_type] {
                self.robj.as_typed_slice().unwrap()
            }
            
            #[doc = "Returns a mutable slice of the underlying data"]
            pub fn as_slice_mut(&mut self) -> &mut [$scalar_type] {
                self.robj.as_typed_slice_mut().unwrap()
            }
...

Does this mean for all wrappers, they automatically get the as_slice_mut() method?

from extendr.

CGMossa avatar CGMossa commented on June 5, 2024

I do like AsTypedSlice as it is a versatile, powerful interface, and we should probably not hide that...

Alternatively, to solve this particular challenge, we could amend the rust's r-vector types with the following (done in gen_vector_wrapper_impl-macro)

        impl $type {
            #[doc = "Returns a slice of the underlying data"]
            pub fn as_slice(&self) -> &[$scalar_type] {
                self.robj.as_typed_slice().unwrap()
            }
            
            #[doc = "Returns a mutable slice of the underlying data"]
            pub fn as_slice_mut(&mut self) -> &mut [$scalar_type] {
                self.robj.as_typed_slice_mut().unwrap()
            }
...

Particularly for Integers, this would yield &[Rint]/&mut [Rint] which would ensure that NA is handled properly, in zero-allocation manner...

from extendr.

CGMossa avatar CGMossa commented on June 5, 2024

Alternatively, to solve this particular challenge, we could amend the rust's r-vector types with the following (done in gen_vector_wrapper_impl-macro)

        impl $type {
            #[doc = "Returns a slice of the underlying data"]
            pub fn as_slice(&self) -> &[$scalar_type] {
                self.robj.as_typed_slice().unwrap()
            }
            
            #[doc = "Returns a mutable slice of the underlying data"]
            pub fn as_slice_mut(&mut self) -> &mut [$scalar_type] {
                self.robj.as_typed_slice_mut().unwrap()
            }
...

Does this mean for all wrappers, they automatically get the as_slice_mut() method?

Yes. Is that a problem?

from extendr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.