Comments (15)
@cgahr @maxhoffmann I think this improves the diagnostics a lot, there is an argument to be made if one should not be able to define a full theme path. but that's a story for another day
from gitui.
@cgahr please try again with current master (f0f90a8) which should also print the path of the theme that errors
from gitui.
just tried and on master aswell on the version you use via brew exactly your theme changes work as expected.
from gitui.
@extrawurst Is there any way to tell gitui that it should log which themes it loads and in which folder it looks? This would really help debugging this on my machine.
from gitui.
please run with -l
to enable logging, see https://github.com/extrawurst/gitui#diagnostics
and share the log created. also helpful is checking if echo $HOME
and echo ~
return the right user folder where you store the config
from gitui.
@maxhoffmann still an issue? any findings via the log option?
from gitui.
@extrawurst unfortunately yes. there are no entries in the log file about loading a config. echo $HOME
and echo ~
return the correct path
from gitui.
@maxhoffmann can you please try to build from source? in be10d90 I added logging theme loading errors to the logfile
from gitui.
I experience a similar issue.
The logging added in be10d90 does not seem sufficient to debug this issue, since it does not print WHICH theme is loaded.
from gitui.
I can confirm the -t <path>
and --theme <path>
both have no effect.
To reproduce:
- remove last
)
from~/.config/gitui/theme.ron
so that the resulting config is not a valid.ron
file - run
./target/debug/gitui -l -t doesnotexist
The relevant line in the log file is
06:31:53 [ERROR] theme error ["/home/cgahr/.config/gitui/theme.ron"]: 28:1: Unexpected end of RON
As you can see, gitui is complaining that the config is not valid (which it is correct because I broke it), however, it should complain that the theme doesntexist
does not exist. Instead, as far as I can tell, it doesn't even try to read the file.
from gitui.
i think i know where the confustion comes from. the provided parameter is a filename, not a path. right now you cannot change the path but only the filename that's loaded from the config path.
plus it silently fallback the default theme file name if the provided one is not a valid filename in that config path
from gitui.
please test the version in the PR #2077
from gitui.
I see, that explains why I wasn't able to change the theme, it was not in the config folder!
I can confirm that -t <file-in-config-dir>
works as intended then.
However, #2077 doesn't work correctly, I don't get a log entry if I try to use a nonexistent theme.
from gitui.
now with da610e7 it works for me:
gitui -t foo.bar
logs:
15:52:49 [ERROR] theme error ["/Users/stephan/.config/gitui/foo.bar"]: No such file or directory (os error 2)
from gitui.
I can confirm, at da610e7 every works now correctly. I think you can close this issue.
from gitui.
Related Issues (20)
- gitui pulls a yanked dependency when installing with cargo HOT 6
- Support defaultKeyCommand for [gpg "ssh"] setting
- Automatic publishing to Winget HOT 1
- [ssh signing] support custom signing program HOT 2
- Fetch Failed: Repository Not Found
- Support for recursive blame HOT 1
- Filter git-log for directory HOT 2
- Mising `:` after the key of sign-off trailer HOT 1
- Enable reverse comparing between branches
- Quick scroll-to-top/bottom shortcuts in branch-list popup
- Make file preview scrollable
- adding unstaged changes when not in "work tree" yields only ambiguous error
- "Bad credentials" error when pulling in gitui, works fine using `git pull` HOT 2
- Quickly navigate to line number in blame view HOT 1
- `cargo install gitui` fails with multiple errors HOT 2
- Wrong diff highlighting for "no newline at end of file"
- Build fails HOT 1
- The lock file for v0.26.2 is out of sync HOT 2
- Loading theme, seems broken HOT 6
- UI colors change dramatically between 0.26.1 and 0.26.2 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitui.