Prevent restarting unifi-os from rebooting UDM again

[fabianishere]

Prevent restarting unifi-os from rebooting UDM again

[fabianishere]

That should indeed not be happening. I'll try to address this soon.

[TheJulianJES]

Just got around to trying this again (with the same original version of udm-kernel/udm-kernel-tools I installed where I remember having this issue previously): It didn't happen again.
I only experienced this issue once where I entered unifi-os restart and the whole system rebooted (got the "Starting..." circle thing on the display of the UDMP twice (as expected when doing a full restart with a custom kernel)) and also had routing temporarily "disabled".
Since then, I always avoided unifi-os restart.

But as I was also unable to reproduce this issue now, I'll close it. Seems to work as expected.
Perhaps it was user error of some sort? (Thanks for trying to debug this!)

[fabianishere]

Hmm, I can't seem to reproduce the issue. As far as I know, it should not reboot if it detects that it is already running a custom kernel.

See the following code:

udm-kernel-tools/udm-bootctl

Lines 223 to 234 in 38744c3

	if ssh-proxy "test -f /.udm-kernel-tools"; then
	echo "Successfully booted into custom kernel.."
	# Remove mark to indicate that we are booting into a custom kernel
	rm -f /mnt/persistent/.udm-boot-mark
	exit 0
	elif [ -f /mnt/persistent/.udm-boot-mark ]; then
	echo "Custom kernel boot seems to have failed. Aborting..."
	exit 1
	else
	touch /mnt/persistent/.udm-boot-mark
	bootctl_boot
	fi

[TheJulianJES]

Huh, that seems weird. I'm pretty sure my system "double restarts" when doing unifi-os restart. I'm still running the initial version though. I'll try to reproduce it later and also upgrade.

Not sure if that's related, but I enabled the auto restart thing that kexec gives you at installation (wasn't mentioned in the guide and I thought it might be needed for the auto restart to work).