Protected keys in JSON items after calling json.dumps on benedict

[gschoenberger]

Protected keys in JSON items after calling json.dumps on benedict

[fabiocaccamo]

@gschoenberger I'm pretty sure it's related to the new keyattr feature, could you try to disable it?

[fabiocaccamo]

In the end I enabled it by default: https://github.com/fabiocaccamo/python-benedict#keyattr

The problem you reported has its origins here: https://github.com/fabiocaccamo/python-benedict/blob/main/benedict/dicts/keyattr/keyattr_dict.py#L26

When getting an attribute, if it doesn't exist yet it is set on the fly on the dict for allow chaining on set item operations, eg. my_dict.new_key.another_new_key.x = 1.0

Probably your code tries to call those attrs on the dict, and for the reason above they are created on the fly.

A solution could be to restrict the automatic keys creation only for keys that doesn't start with an _, what do you think? Any suggestion is appreciated.

[fabiocaccamo]

@gschoenberger thank you for reporting this.

Any changes related to dumping/loading benedicts to/from JSON?

Not at all.

[gschoenberger]

@gschoenberger thank you for reporting this.

Any changes related to dumping/loading benedicts to/from JSON?

Not at all.

Mh. We will investigate this further next week and let you know!

[gschoenberger]

Thanks for the hint, we disabled the keyattr feature and unit tests passed!

def __init__(self, data: Optional[Dict[Any, Any]] = None) -> None:
    self.data = benedict(keyattr_enabled=False) if data is None else benedict(data, keyattr_enabled=False)

Shouldn't it be disabled by default? (according to the README)
By default this feature is disabled due to its implicit limitations: it works only for string keys and only if the keys don't clash with the supported methods names.

[fabiocaccamo]

Fixed in 0.29.1.

[gschoenberger]

Great,, thanks!