Fails when parent dir contains files/dirs that you don't have permission for

[beorn]

Fails when parent dir contains files/dirs that you don't have permission for

[beorn]

I got this exception when running tests on CI (github actions):

⎯⎯⎯⎯ Unhandled Rejection ⎯⎯⎯⎯⎯
Error: EACCES: permission denied, watch '/tmp/snap.lxd'
 ❯ FSWatcher.<computed> node:internal/fs/watchers:244:19
 ❯ Object.watch node:fs:2315:34
 ❯ Watcher.watchDirectories node_modules/watcher/dist/watcher.js:192:40

 ❯ node_modules/watcher/dist/watcher.js:234:36
 ❯ async /home/runner/work/proj/proj/node_modules/watcher/dist/watcher.js:123:17

Btw, the workaround that @dividedmind mentioned works for me — just using:

const watcher = new Watcher(root, { ignore: (path) => !path.startsWith(root) });

[beorn]

I didn’t have the issue on macOS, but when I ran into it when trying to run tests on CI via GitHub actions. I thought it was a general permission issue, but maybe it’s related to Linux or the GitHub actions runtime?

…

On Nov 19, 2022, at 16:46, Fabio Spampinato ***@***.***> wrote: I can't reproduce the issue under macOS with this code: import fs from 'node:fs'; import Watcher from 'watcher'; const root = await fs.promises.mkdtemp(path.resolve(os.tmpdir(), "my-")); const watcher = new Watcher(root); @beorn <https://github.com/beorn> can you reproduce the issue just with this? If so I'll test under my Linux VM. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACC35YAERWWPK4F7OFUVTWJFYE5ANCNFSM57YEV5HA>. You are receiving this because you were mentioned.

[dividedmind]

@beorn One workaround is to use ignore parameter:

const watcher = new Watcher(root, { ignore: (path) => !(path.startsWith(root) || root.startsWith(path)) });

This will skip examining everything with is not a direct ancestor or descendant of root.

[beorn]

@dividedmind Thanks, that seems to work!

I got it working without root.startsWith(path) — in which case is that needed?

[dividedmind]

@dividedmind Thanks, that seems to work!

I got it working without root.startsWith(path) — in which case is that needed?

Strange, for me it didn't work without this — it led to ignoring /tmp and /, pruning out the whole universe. Maybe because I used { recursive: true }? Or maybe I'm misremembering. :)

[beorn]

I was also using { recursive: true }... Hm... Maybe related to symbolic links or relative paths? 🤷

[dividedmind]

I was also using { recursive: true }... Hm... Maybe related to symbolic links or relative paths? shrug

I might have been watching a root which didn't initially exist.

[fabiospampinato]

Not try to stat anything but the direct ancestors of the path you're in (so /tmp and /tmp/my-* only) - not all children of parent

That's necessary for the watcher to work correctly.

Provide a way to turn off parent watching

That would also cause bugs if turned off.

Gracefully handle these kinds of errors

Sure, I should probably add some tests for this use case. Was the watcher throwing or just emitting error events for you?

[fabiospampinato]

I can't reproduce the issue under macOS with this code:

import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
import Watcher from 'watcher';

const root = await fs.promises.mkdtemp(path.resolve(os.tmpdir(), "my-"));
const watcher = new Watcher(root);

@beorn can you reproduce the issue just with this? If so I'll test under my Linux VM.

[fabiospampinato]

I can't reproduce it under my linux VM either, maybe github actions are doing something weird, I'll look at that but low priority for now.

[chumager]

Hi, it seems like the snap.lxd is a snap virtual disk, and maybe that's why you can't reproduce the error.
https://snapcraft.io/lxd

Regards.

[fabiospampinato]

Possibly, but I need to reproduce the issue, hopefully much more easily than using snap, to figure out how to fix it. I tried messing with permissions and stuff and I couldn't reproduce the issue.

[dividedmind]

Possibly, but I need to reproduce the issue, hopefully much more easily than using snap, to figure out how to fix it. I tried messing with permissions and stuff and I couldn't reproduce the issue.

Did you try creating something in /tmp which is not accessible by the user before trying to reproduce? Ie. sudo mkdir /tmp/no-entry; sudo chmod 0700 /tmp/no-entry.

[fabiospampinato]

I don't remember if in /tmp, but I did try to mess with permissions with no luck. If somebody can paste some code that reproduces the problem it'd be useful 👍