Login configuration

[joshuawilson]

Login configuration

[jstrachan]

so I'm thinking we either:

(i) refactor the login stuff in fabric8-runtime-console into a service that we can opt out of in fabric8-ui and just use ngx-login-client directly or

(ii) refactor the core parts of fabric8-runtime-console out as an npm module (or separate repo) and let the login stuff sit in fabric8-ui

(iii) have 2 separate components that extend fabric8-runtime-console; one that uses vanilla OAuth in OpenShift; the other that uses ngx-login-client

As we need fabric8-runtime-console that runs on vanilla Kubernetes/OpenShift without using ngx-login-client so that we can just talk OAuth to OpenShift/Keycloak.

I'm guessing ngx-login-client can't handle the case where fabric8-runtime-console is running as a client directly on OpenShift with no planner/core API backend right?

[joshuawilson]

Or we can update the login-client to handle generic oauth

[jstrachan]

yeah - current plan is I think to

• patch ngx-login-client so it can be configured to either use generic OAuth (e.g. angular2-oauth2) or use KeyCloak/Almighty stuff
• patch fabric8-runtime-console to use ngx-login-client for its login stuff

[jstrachan]

lets separate out the "make ngx-login-client support vanilla OAuth" issue fabric8-ui/ngx-login-client#20

then this issue becomes mostly 'migrate to ngx-login-client"