Giter Site home page Giter Site logo

Comments (3)

jstrachan avatar jstrachan commented on August 18, 2024

this is similar to #31; if docker.registry isn't specified as a mvn property it'd be nice to default to DOCKER_REGISTRY env var

from docker-maven-plugin.

rhuss avatar rhuss commented on August 18, 2024

Let's reconsider the whole registry addressing stuff:

Currently it is only possible to specify a private registry as part of the image name, but a more flexible naming would be add some value.

My suggestion is:

  • If the image name contains a registry, then this registry has the highest precedence.
  • Otherwise, if the ImageConfiguration specifies a registry, take this.
  • Otherwise, if the global configuration contains a registry, take this for all images.
  • Otherwise check the system property docker.registry
  • Finally check an environment variable DOCKER_REGISTRY.

If an image is build, and the registry is not specified in the name, it should be tagged with the full name (including the registry found), too.

When it is pushed and the image to push is not 'fully' qualified (i.e. doesn't contain a registry part), but another than the default registry is configured, tag the image locally before pushing to the target registry (if this is required by docker, don't know this by heart)

from docker-maven-plugin.

rhuss avatar rhuss commented on August 18, 2024

DOCKER_REGISTRY is now used as a fallback in 0.11.1 and later, so it should be safe. I'll close that one, please feel free to reopen it if it shouldn't work as expected (and described in the manual).

from docker-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.