Comments (3)
this is similar to #31; if docker.registry isn't specified as a mvn property it'd be nice to default to DOCKER_REGISTRY env var
from docker-maven-plugin.
Let's reconsider the whole registry addressing stuff:
Currently it is only possible to specify a private registry as part of the image name, but a more flexible naming would be add some value.
My suggestion is:
- If the image name contains a registry, then this registry has the highest precedence.
- Otherwise, if the
ImageConfiguration
specifies a registry, take this. - Otherwise, if the global configuration contains a registry, take this for all images.
- Otherwise check the system property
docker.registry
- Finally check an environment variable
DOCKER_REGISTRY
.
If an image is build, and the registry is not specified in the name, it should be tagged with the full name (including the registry found), too.
When it is pushed and the image to push is not 'fully' qualified (i.e. doesn't contain a registry part), but another than the default registry is configured, tag the image locally before pushing to the target registry (if this is required by docker, don't know this by heart)
from docker-maven-plugin.
DOCKER_REGISTRY is now used as a fallback in 0.11.1 and later, so it should be safe. I'll close that one, please feel free to reopen it if it shouldn't work as expected (and described in the manual).
from docker-maven-plugin.
Related Issues (20)
- RegistryServiceTest : remove unused variable `hasImage` and `dockerFileUtilMockedStatic` HOT 3
- LogRequestor : Replace `com.google.common.base.Charsets.UTF_8` with `StandardCharsets.UTF_8` HOT 5
- Turning on JIB mode breaks multi-assembly images HOT 2
- <run><wait> no longer working correctly
- Cannot find default setter in class io.fabric8.maven.docker.config.ImageConfiguration while trying to execute docker:start goal HOT 1
- Can't use <packaging>docker</packaging> in a multi-module project HOT 1
- Version 0.44.0 fails to use the `<args>` configuration to populate the Docker build-args HOT 5
- support Dockerfile RUN <<EOF HOT 1
- docker:push failed with ARG in FROM HOT 5
- DockerComposeServiceWrapper : Use `isEmpty()` to check collection is empty HOT 3
- WatchService : Anonymous `new Runnable()` can be replaced with lambda HOT 5
- Quickstarts : Improve `it/spring-boot-with-jib` integration test HOT 2
- Ability to
- Error Encountered When Building Multi-Architecture Docker Images Using docker-maven-plugin HOT 1
- Write portPropertyFile as soon as the container is started
- Unable to push docker images to Nexus using "docker-maven-plugin" HOT 1
- External Compose and Wait seems not working HOT 1
- Expected a com.google.gson.JsonObject but was com.google.gson.JsonArray
- Follow settings ingored unless specified from command line HOT 1
- How to mount secrets on build?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-maven-plugin.