Karaf image - Adds APP_BASE to env.sh during installation

[davsclaus]

Karaf image - Adds APP_BASE to env.sh during installation

[davsclaus]

@jstrachan what is the intention of APP_BASE, should it be directory where apache-karaf was unzipped, or the root of the image?

The structure is

env.sh
run.sh
...
apache-karaf-2.4.0
apache-karaf-2.4.0/bin

[jstrachan]

the root of the installation (where run.sh is).

FWIW folks could expand apache-karaf-2.x into the root dir; there's not a huge need to have a sub folder to host karaf; since there should not be any overlaps between the files in the root directory and those inside karaf; though I guess there's no real harm. Though by not having the extra sub directory it means the default logic of chmod of .sh and bin/.sh would just work

[jstrachan]

I'd be tempted to remove the extra karaf folder; it makes things a little easier to use

[jimmidyson]

@jstrachan @davsclaus ok i'll do that now - it was just the unzip of the maven tar.gz artifact, but I'll fix up the assembly to put that straight in the root

[davsclaus]

Thanks @jimmidyson - I couldn't get that assembly packaging.xml to skip that dir, so I can see you found the solution to use fileSet and unpack it from somewhere else.

Sometimes Maven is just way harder than a ant script, where this would have been easier ;)

[jimmidyson]

@davsclaus can you try out this updated image? i haven't got jube set up yet - doing so right now, but if you've got a moment to try this updated image out that would be cool.

[davsclaus]

Works now, thanks