Rails 5: undefined method `as_api_response' for ActiveRecord_Associations_CollectionProxy

[shaicoleman]

Rails 5: undefined method `as_api_response' for ActiveRecord_Associations_CollectionProxy

[fabrik42]

Hi! Thank you for the bug report. Unfortunately I think I will not be able to take a look at it before next week, but I am happy to have a look at a pull request.

I think a workaround until then would be to convert the collection to an array:

render_for_api :default, json: project_with_tasks.tasks.to_a

The as_api_response method gets mixed into AR objects as well as into the Array class. Maybe we now need to mix it into another Object as well. I just want to make sure we don't clutter the namespaces of foreign classes if we don't need to.

[shaicoleman]

I've tried .to_a but it changes the response format.

I didn't manage to fix it myself, so if you can look at it sometime next week, that'll be great.

[fabrik42]

Ok, I will let you know if I find something out.

[fabrik42]

Just a little update: I can reproduce the problem in the spec suite after updating it to Rails 5. A lot of stuff is breaking, but I'm making progress.

[shaicoleman]

Thanks for looking into that, I really appreciate that

[fabrik42]

Hey, I just uploaded a branch you might want to test:

• #101
• https://github.com/fabrik42/acts_as_api/tree/rails5

I still need to make sure there are no regression bugs with older Rails versions and a little bit of polishing, but I think we can merge this soon.

[shaicoleman]

Thanks for all your work. I can confirm the rails5 branch fixes this issue for me.

[fabrik42]

This is the only regression that prevents the branch from being merged: #98

[shaicoleman]

I've done a couple more tests, and I'm seeing a couple more similar issues of the above, so it's not 100% fixed, working now on creating a reproducible case.

[fabrik42]

Very cool, thanks!

[shaicoleman]

Replacing ActiveRecord::Delegation with ActiveRecord::Relation in lib/acts_as_api.rb fixes the issue for me:

  if defined?(ActiveRecord::Delegation)
    ActiveRecord::Delegation.include(ActsAsApi::Collection)
  end

  if defined?(ActiveRecord::Relation)
    ActiveRecord::Relation.include(ActsAsApi::Collection)
  end

[fabrik42]

Can you provide me some failing examples so I can extend the spec suite?

[shaicoleman]

I've updated the sample app to show the issue also with the latest rails5 branch: https://github.com/shaicoleman/acts-as-api-bug

I've dug down to the root cause, and it seems to be a conflict between acts_as_api and the protected_attributes_continued gem, when the protected_attributes_continued gem is loaded first.

The workaround is either to replace ActiveRecord::Delegation with ActiveRecord::Relation or change the load order, so protected_attributes_continued loads after acts_as_api.

I don't think this is something we can test for

[fabrik42]

Wow, thanks for updating the example app, this helped me a lot!

I am not sure why this happens, I guess the protected attributes gem changes internals from ActiveRecord. However, I think it is fine to include the collection helpers in every single AR relation class, instead of the delegation class.

I updated the PR branch accordingly.

For the other regression I was seeing, I opened a ticket in the rails repo. I am not sure of this is now intended behavior or a bug in rails. rails/rails#26959

[fabrik42]

@shaicoleman I think I fixed the last bug. It was a mistake on my side :\

If you can confirm that the rails 5 branch works for you, I will merge it and release a new version of the gem.

[shaicoleman]

Looks good, but I think you need to bump the version higher, either to 0.5.0 or to 1.0.0

[fabrik42]

Yes, I will bump the version before the release :)

Shai Coleman schrieb:

Looks good, but I think you need to bump the version higher, either to
0.5.0 or to 1.0.0

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#100 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANqTuwQfDhh08Q7_B_z-ALeh5FA818mks5q8J-ZgaJpZM4KcGMq.

[fabrik42]

Hey, I just released a new version of the gem. After the last fixes it should be completely backwards compatible, so I am releasing it under the version 0.4.4.

https://rubygems.org/gems/acts_as_api/versions/0.4.4

Thanks again for your help!