Logic error of UIView's extension function: cornerRadius(corners: UIRectCorner, radius: CGFloat)

[fabriziobrancati]

Logic error of UIView's extension function: cornerRadius(corners: UIRectCorner, radius: CGFloat)

[kokitang]

if corners.contains(.bottomLeft) {
                    cornerMask.update(with: .layerMinXMinYCorner)
                }
                if corners.contains(.bottomRight) {
                    cornerMask.update(with: .layerMaxXMinYCorner)
                }
                if corners.contains(.topLeft) {
                    cornerMask.update(with: .layerMinXMaxYCorner)
                }
                if corners.contains(.topRight) {
                    cornerMask.update(with: .layerMaxXMaxYCorner)
                }

Should be:

if corners.contains(.bottomLeft) {
                    cornerMask.update(with: .layerMinXMaxYCorner)
                }
                if corners.contains(.bottomRight) {
                    cornerMask.update(with: .layerMaxXMaxYCorner)
                }
                if corners.contains(.topLeft) {
                    cornerMask.update(with: .layerMinXMinYCorner)
                }
                if corners.contains(.topRight) {
                    cornerMask.update(with: .layerMaxXMinYCorner)
                }

[kokitang]

in iOS 10:

in iOS 11:

Code:
cornerRadius(corners: [.topLeft, .topRight, .bottomRight], radius: 16)

[FabrizioBrancati]

Thanks! Why not open a pull request? 😄
Just a question, they changed the Y asix on iOS 11?

[kokitang]

Haha.. My source control software having some issue on push code to GitHub..

I don't think they changed the Y axis stuffs on iOS 11 due to coordinate x: 0, y: 0 is top-left corner. And in your original code you state .bottomLeft is minimum X and minimum Y, so it's not correct obviously.

[FabrizioBrancati]

Ahah ok I will fix it.
I don't understand your previous comment, both the images are generated by the same code cornerRadius(corners: [.topLeft, .topRight, .bottomRight], radius: 16)?
Or is a "How is now" and "How has to be"?

[FabrizioBrancati]

@kokitang News about that issue?