AkdKey and Values should be standardized

[facebook]

AkdKey and Values should be standardized

[slawlor]

AkdLabel and AkdValue are ok to me. @kevinlewi and opinion here?

Additionally instead of &[u8] which is size unknown at compile time, we should probably look at Vec<u8> since Rust won't allow unsized as a struct property.

[kevinlewi]

I like the suggested naming conventions! Yes, let's go with AkdLabel, AkdValue, and having them be Vec<u8>

[eozturk1]

That sounds good! :)

[eozturk1]

SEEMless uses the terms Label and Value for key and value, respectively.

My preference would be the following change: AkdKey -> Label and Values -> Value. This also side-steps the issue of using "key" to name the labels while storing (crypto) keys as values.

Other suggestions?

[eozturk1]

To prevent the confusion with NodeLabels, we could use AkdLabel and AkdValue?

[slawlor]

If you haven't already started on this @eozturk1 can I take it back for a camper? We have a new camper who this is a great intro-level task for them (and get's them into OSS).

Thanks!

[slawlor]

This appears completed. Closing issue