Ubuntu 18.04 build error

[facebook]

Ubuntu 18.04 build error

[zhichao-cao]

It reports the same error on Ubuntu 20.04

/usr/bin/ld: /home/CacheLib/opt/cachelib/lib/libthriftcpp2.so.1.0.0: undefined reference to apache::thrift::TrustedServerException::requestParsingError(char const*)' /usr/bin/ld: /home/CacheLib/opt/cachelib/lib/libthriftcpp2.so.1.0.0: undefined reference to apache::thrift::TrustedServerException::unimplementedMethodError(char const*)'
collect2: error: ld returned 1 exit status
make[2]: *** [common/CMakeFiles/common-test-BloomFilterTest.dir/build.make:145: common/common-test-BloomFilterTest] Error 1
make[1]: *** [CMakeFiles/Makefile2:602: common/CMakeFiles/common-test-BloomFilterTest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

[agordon]

@zhichao-cao thanks for the report, will post a fix soon.

[zhichao-cao]

@zhichao-cao thanks for the report, will post a fix soon.

Thanks, also this failure appears when it links the cache bench:

/zhichao/CacheLib/opt/cachelib/lib/libzstd.so /usr/lib/x86_64-linux-gnu/libsnappy.so /usr/lib/x86_64-linux-gnu/libdwar
f.so /usr/lib/x86_64-linux-gnu/libiberty.a /usr/lib/x86_64-linux-gnu/libsodium.so -ldl /usr/lib/x86_64-linux-gnu/libun
wind.so /home//CacheLib/opt/cachelib/lib/libgflags_debug.so.2.2.2 -lpthread
/usr/bin/ld: /home/CacheLib/opt/cachelib/lib/libthriftcpp2.so.1.0.0: undefined reference to apache:: thrift::TrustedServerException::requestParsingError(char const*)' /usr/bin/ld: /home/CacheLib/opt/cachelib/lib/libthriftcpp2.so.1.0.0: undefined reference to apache::
thrift::TrustedServerException::unimplementedMethodError(char const*)'
collect2: error: ld returned 1 exit status
make[2]: *** [cachebench/CMakeFiles/cachebench.dir/build.make:145: cachebench/cachebench] Error 1
make[2]: Leaving directory '/home/CacheLib/build-cachelib'
make[1]: *** [CMakeFiles/Makefile2:647: cachebench/CMakeFiles/cachebench.dir/all] Error 2
make[1]: Leaving directory '/home/CacheLib/build-cachelib'
make: *** [Makefile:136: all] Error 2
build-package.sh: error: make failed
build.sh: error: failed to build cachelib