Giter Site home page Giter Site logo

Comments (4)

agordon avatar agordon commented on April 19, 2024

Thanks for the detailed log @michel-slm , I'm working on a fix.

from cachelib.

therealgymmy avatar therealgymmy commented on April 19, 2024

@agordon: this is the diff that broke the build: c4636ee

We had an automated code-mod internally to simplify some fb thrift API calls. It passed builds internally but broke here. I didn't look deeply in why this was broken.

from cachelib.

agordon avatar agordon commented on April 19, 2024

The removal of _ref() suffix from Thrift-generated files is a recent feature of 'thrift', though it seems the code generated internally differs slightly from the code we get when building fbthrift locally. Main symptom is that thrift objects with fields marked as required ( e.g. https://github.com/facebook/CacheLib/blob/main/cachelib/allocator/serialize/objects.thrift#L48 ) still generate only the accessors with the _ref() suffix. This is being investigated...

from cachelib.

michel-slm avatar michel-slm commented on April 19, 2024

Fixed in facebook/fbthrift@44aec79

from cachelib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.