Enablement of `unified_mode` for v17+ Chef client compatibility

[facebook]

Enablement of `unified_mode` for v17+ Chef client compatibility

[jaymzh]

We will likely need to set it to false for our more complicated resources in the short-term. Especially fb_networking_scripts is super complicated and does a lot of trickery (that is probably easier in unified mode, but will require work).

[dafyddcrosby]

Per @jaymzh's earlier comment:

We will likely need to set it to false for our more complicated resources in the short-term.

That's what I've ended up doing in 56b5304, and I'll be going through the resources in the coming weeks to ratchet those resources to unified_mode true (though happy to review PRs that beat me to it :-)

[taylorific]

Bravo! Thank you!

[taylorific]

Thank you very much for landing this! I've been testing these cookbooks against Chef 18 for a few weeks now in our fleet. The only real issue I've discovered so far is that there's some weird issue around notifications with the networking resources (as @jaymzh pointed out). As a workaround, I just did the following in our version of fb_init. Though we haven't exhaustively tested every cookbook in chef-cookbooks. Will test again now with this unified_mode true changes rolled in without deleting the fb_helpers_gated_template resource, to see if it works any better.

if node.systemd?
  include_recipe 'fb_systemd'
  # Don't allow management of /etc/systemd/networkd.conf - has weird
  # issues with notifications
  delete_resource(:fb_helpers_gated_template, '/etc/systemd/networkd.conf')
  include_recipe 'fb_timers'
end