Giter Site home page Giter Site logo

Comments (5)

adamjernst avatar adamjernst commented on April 23, 2024

Opinions. I dislike umbrella headers generally. (Probably influenced by the fact that we dislike them at Facebook generally...)

from componentkit.

jlpiedrahita avatar jlpiedrahita commented on April 23, 2024

Most system frameworks and 3rd party libraries/frameworks do it.

Can you expand on why you think this should not be done? Personally I find it annoying to have to know which file to include for each symbol I need, it's not always obvious.

from componentkit.

adamjernst avatar adamjernst commented on April 23, 2024

Well, I wouldn't be opposed to a pull request I guess. We can always disallow its use internally.

(With the sheer amount of code we have, we find umbrella headers end up bloating compilation times and result in huge numbers of symbols available. But for most smaller projects it's not an issue at all.)

from componentkit.

kastiglione avatar kastiglione commented on April 23, 2024

👍 I like giving the option, particularly since they're very conventional.

from componentkit.

kastiglione avatar kastiglione commented on April 23, 2024

This relates to #44.

from componentkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.