Comments (12)
They're called on CKComponentController
, not CKComponent
instances.
from componentkit.
Yeah, that is what I actually meant, see title. They are not called on ComponentController.
from componentkit.
Ah I see. Can you submit an example project?
from componentkit.
This does happen in Example project, simply add InteractiveQuoteComponentController with those methods.
-(void).*mount methods are properly called, those 4 - not.
from componentkit.
componentDidAcquireView
and componentWillRelinquishView
will not be called because InteractiveQuoteComponent
itself does not have a view. (Only its sub-component CKStackLayoutComponent
does.)
However componentTreeWillAppear
and componentTreeDidDisappear
should be called. That warrants further investigate.
from componentkit.
Verified this is a bug. Assigning @benlodotcom to fix.
from componentkit.
Actually I'll take it
from componentkit.
It works, thank you.
There is another thing now.
Currently, if you ask dataSource for not existing indexPath, it will crash since there is direct access to NSArray[index].
What happens for me is that I delete a cell and receive didEndDisplayingCell, the app crashes on announceDidDisappearForItemAtIndexPath because the model was deleted.
It might be better to simply return nil I guess.
Minor thing since I can actually check in my model, but still...
from componentkit.
That's bad — opened #129 to track.
from componentkit.
@myeyesareblind Hi guy! Can you help me to submit your example project to me? Thank you very much!
from componentkit.
@thanhturin what exact issue are you working on? componentTreeWillAppear is fixed now
from componentkit.
@myeyesareblind : I'm sorry about my late reply! I had the same problem 3 days ago. But i already fixed it. Thank you for your listening :)
from componentkit.
Related Issues (20)
- Component not release
- [Documentation] Views path is not render HOT 3
- Delete 'Carthage/Checkouts' directory
- question - docs (docusaurus) repo? HOT 2
- Xcode not building ComponentKit checked out via cocoapods HOT 2
- Docusaurus source code
- question: My component is not getting full width in screen landscape mode. HOT 1
- Not Support Incremental mount
- Build Error with "RenderCoreLayoutCaching" HOT 1
- ComponentKit does not compile with Xcode 12.5 HOT 1
- Compile Error: Block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior HOT 1
- How do I pass multiple arguments
- Unsupported Swift Version: “FBSnapshotTestCase iOS” contains source code developed with Swift 3.x.
- [Question]How to unmount components from HostingView?
- How to make children component height equal to Scroll component's content view height but Scroll component's height HOT 2
- Yoga-internal.h:135:11: error: definition of implicit copy constructor for 'Values<9>' is deprecated
- CKNonNull.h:47:33 No member named 'move' in namespace 'std'; did you mean 'modf'?
- Abandoned?
- ComponentKit/ComponentKit.xcconfig is compiled as source code
- Unable to compile example project
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from componentkit.