Giter Site home page Giter Site logo

Comments (12)

adamjernst avatar adamjernst commented on March 29, 2024

They're called on CKComponentController, not CKComponent instances.

from componentkit.

myeyesareblind avatar myeyesareblind commented on March 29, 2024

Yeah, that is what I actually meant, see title. They are not called on ComponentController.

from componentkit.

adamjernst avatar adamjernst commented on March 29, 2024

Ah I see. Can you submit an example project?

from componentkit.

myeyesareblind avatar myeyesareblind commented on March 29, 2024

This does happen in Example project, simply add InteractiveQuoteComponentController with those methods.
-(void).*mount methods are properly called, those 4 - not.

from componentkit.

adamjernst avatar adamjernst commented on March 29, 2024

componentDidAcquireView and componentWillRelinquishView will not be called because InteractiveQuoteComponent itself does not have a view. (Only its sub-component CKStackLayoutComponent does.)

However componentTreeWillAppear and componentTreeDidDisappear should be called. That warrants further investigate.

from componentkit.

adamjernst avatar adamjernst commented on March 29, 2024

Verified this is a bug. Assigning @benlodotcom to fix.

from componentkit.

adamjernst avatar adamjernst commented on March 29, 2024

Actually I'll take it

from componentkit.

myeyesareblind avatar myeyesareblind commented on March 29, 2024

It works, thank you.
There is another thing now.
Currently, if you ask dataSource for not existing indexPath, it will crash since there is direct access to NSArray[index].
What happens for me is that I delete a cell and receive didEndDisplayingCell, the app crashes on announceDidDisappearForItemAtIndexPath because the model was deleted.
It might be better to simply return nil I guess.
Minor thing since I can actually check in my model, but still...

from componentkit.

adamjernst avatar adamjernst commented on March 29, 2024

That's bad — opened #129 to track.

from componentkit.

thanhturin avatar thanhturin commented on March 29, 2024

@myeyesareblind Hi guy! Can you help me to submit your example project to me? Thank you very much!

from componentkit.

myeyesareblind avatar myeyesareblind commented on March 29, 2024

@thanhturin what exact issue are you working on? componentTreeWillAppear is fixed now

from componentkit.

thanhturin avatar thanhturin commented on March 29, 2024

@myeyesareblind : I'm sorry about my late reply! I had the same problem 3 days ago. But i already fixed it. Thank you for your listening :)

from componentkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.