Giter Site home page Giter Site logo

Comments (13)

vjeux avatar vjeux commented on March 29, 2024 3

And I grabbed the npm module

from create-react-app.

lacker avatar lacker commented on March 29, 2024 2

It might also be neat if there were scripts like install-redux,install-relay, install-jest. Those could do a bit of codemodding and some npm installing to automate common other ecosystem tools. Also just throwing the idea out there.

from create-react-app.

lacker avatar lacker commented on March 29, 2024

For codemodding itself I like it. I wonder about npm run codemode-foo though. Is the idea to provide more and more tools available via npm run blahblah in the autocreated project over time? It might be nicer to provide some dev tool that had stuff like the "start" and "build" functionality in it, and you could actually keep that tool as a dev dependency while developing. That way, if you had an old project you could upgrade your version of the toolkit.

Like, would npm run upgrade-to-react-16 only be available for projects created after the upgrade-to-react-16 codemod was created? That is sort of not the target audience.

from create-react-app.

kentcdodds avatar kentcdodds commented on March 29, 2024

Might be a place to consider p-s where scripts can be dynamic and updated as people upgrade their projects to the new version of the CLI (without having to update a [growing] package.json scripts)

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

@lacker

Totally, we’d need to change how we use scripts for this.

Might be a place to consider p-s where scripts can be dynamic and updated as people upgrade their projects to the new version of the CLI (without having to update a [growing] package.json scripts)

👍

from create-react-app.

lacker avatar lacker commented on March 29, 2024

So if scripts starts to be useful scripts for different parts of your app's lifecycle, rather than just scripts to start your app up, maybe it would be more accurate to just call the module something like react-scripts. (Which is available afaict)

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Agreed that one script is better (we can still do it btw, just need to change those commands to be a single bin entry point).

Something like install-relay is super interesting but I want this to be something considered for conceptual "v2". Right now the scope is limited to build tooling because even that will take a while to get right. Then we can think about runtime dependencies.

from create-react-app.

lacker avatar lacker commented on March 29, 2024

V2ing install-relay sounds good to me. There is still the question of the name of the dependent package - people are gonna run create-react-app once, but the dependency on what is currently create-react-app-scripts could remain while the app goes into production, new engineers join the team, etc. Let's name it non-create-specifically to keep options open. Thoughts on react-scripts or react-run? (I'll ditch that other react-run project in favor of create-react-app either way.)

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

react-scripts sounds nice, is it free?

from create-react-app.

vjeux avatar vjeux commented on March 29, 2024

react-scripts not found :)

from create-react-app.

vjeux avatar vjeux commented on March 29, 2024

Let me codemod everything to react-scripts in the repo while one of you grab the npm package

from create-react-app.

vjeux avatar vjeux commented on March 29, 2024

756ed3f

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

I’m pretty sure we’ll want to do this at some point, but let’s wait for first codemod to turn up, and then think about it.

from create-react-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.