Giter Site home page Giter Site logo

Comments (17)

insin avatar insin commented on March 29, 2024 1

Sure, I'll try all the commands & scripts from scratch when I get some time and report back.

I'm your worst case user - using npm2 on Windows, running on the cheapest Lenovo laptop Amazon UK had 5 months ago, with a crap CPU and an HDD 😸

Anything which uses vanilla Babel 6 presets is pretty miserable to install on npm2 with this setup due to the duplicated dependencies for each plugin.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024 1

Eh, that’s not fun. Maybe I could exclude whatever depends on fsevents from the bundle but keep the rest bundled.

from create-react-app.

insin avatar insin commented on March 29, 2024 1

Do you have an AppVeyor account to run CI on Windows?

Better to have things checked automatically on all platforms, but new tests would need to be written.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Yeah.. I wonder if we can do something crazy like put all non-binary deps in a tarball or something.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Until the packages are public, you can do this to test the full flow:

npm i -g counter-redux@qwertyuiop
create-react-app whatever --scripts-version react-elmish-example@bundled

from create-react-app.

lacker avatar lacker commented on March 29, 2024

Tried it with npm 2.15.8 (currently the default suggested windows install flow). Tiny problem: the unicode hourglass shows up as a square in powershell. Larger problem: fsevents apparently depends on having python installed. (I don't normally use this as a dev machine.) I'll see if there's a workaround. Here's the error for the record.
nopython

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Interesting. fsevents is optional, on OS X it gets installed for faster rebuilds but webpack should work without it. Can you also try

create-react-app whatever --scripts-version react-elmish-example@no-bundle

to see if fsevents doesn't show up this way?

from create-react-app.

lacker avatar lacker commented on March 29, 2024

Ah I see fsevents is OS X only. With @no-bundle now both the create-react-app phase and the npm start are working for me. I'll poke around to see if I can break anything else.

from create-react-app.

lacker avatar lacker commented on March 29, 2024

Another problem - when I eject and then run start, it can't find webpack any more. But when I manually run a npm install after that, it works fine. I suspect that whatever logic runs an npm install immediately after ejecting is not working on Windows.
eject-then-start

from create-react-app.

lacker avatar lacker commented on March 29, 2024

A little nitpick: the message for npm run build is incorrect on Windows.

You can now serve it with any static server:
  cd build
  python -m SimpleHTTPServer 9000
  open http://localhost:9000

because open isn't a windows thing. AFAICT there is no Windows command line equivalent so unless someone has a good idea maybe just leave this message as is.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Yeah, I was hoping that maybe people would just read it as a word if they know there is no such command. Open to better ideas (can check platform?)

from create-react-app.

lacker avatar lacker commented on March 29, 2024

OK I can't find any more ways to break it. So just two big things, fsevents in the bundle and the eject-then-start problem. Unrelated: @gaearon would you mind briefly checking FB messenger? I just wanted to ask you a quick question there. :P

from create-react-app.

insin avatar insin commented on March 29, 2024

For the build message, you could check for process.platform being 'win32' and use start instead of open.

Windows doesn't ship with a Python installation, though - a handy alternative would be to recommend npm install -g http-server and running hs.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

955ea33

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

I think we’re good. I’ll double check now.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

Okay, final prerelease:

npm i -g counter-redux@qwertyuiop
create-react-app my-app --scripts-version react-elmish-example@pretty-close

from create-react-app.

rooseveltAI avatar rooseveltAI commented on March 29, 2024

Also when installing, if it throws a "JSON" error and crashes, try running this command:

create-react-app appname --save

or create-react-app appname --save-exact and then try again.

if it persists you can try using a newer version of node.

from create-react-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.