Giter Site home page Giter Site logo

Comments (6)

vincaslt avatar vincaslt commented on March 29, 2024 1

I guess something like that could work, tell me if it should be improved. Maybe move required file definitions to somewhat more manageable place?

from create-react-app.

delorge avatar delorge commented on March 29, 2024 1

Is it easier to check that file exists via access check? Should work with any npm version. Moreover, no extra dependencies needed.

UPD: we can basically crash on errors and warn on missing favicon

from create-react-app.

apoorvnandan avatar apoorvnandan commented on March 29, 2024

Hey, I would like to work on this but I need some guidance. Will using npm file-exists before opening the browser do the job?

var fileExists = require('file-exists');
if (!fileExists("/index.html") || !fileExists("/favicon.ico") || !fileExists("/src/index.html")) {
  console.log("File missing");
}
else {
  console.log(chalk.cyan('Starting the development server...'));
  openBrowser();
}

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

I would suggest to try implementing something that works and feels good. When we get the right UX we can choose to make changes to the actual implementation.

from create-react-app.

christophior avatar christophior commented on March 29, 2024

Might take a look at this as well, I see that we already have paths that we're getting in the webpack configs so I was thinking of pulling those out since a lot of it seems like redundant data so that I could also use that in checking whether the required files exist.

from create-react-app.

gaearon avatar gaearon commented on March 29, 2024

This should be fixed in 0.4.2.

from create-react-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.