The SDK blocks on bad HTTP requests (task #467289)

[facebook]

The SDK blocks on bad HTTP requests (task #467289)

[Korriged]

Another example : https://api.facebook.com?method=stream.publish&message=Message&format=json&attachment=%7B%22name%22%3A%22Facebook%22%2C%22href%22%3A%22http%3A%2F%2Fdevelopers.facebook.com%2F%22%2C%22caption%22%3A%22Caption%22%2C%22description%22%3A%22Description%22%7D&access_token=...

But the SDK works when changing to https://api.facebook.com/method/stream.publish?message=Message&...

[eldolor]

Util.openUrl does not support Http socket and connection timeouts, which in turn will prevent threads from hanging for a long period of time. You may want to consider using the org.apache.http.* package within util.openUrl, which has built-in support for timeouts, instead of using java.net.* package for Http communication.

[soneff]

Ya, we should probably swap out the java.net http library for the apache one, which is available on Android. I'm swamped with stuff right now, but if you want to do this and send me a code diff, I can look into getting it integrated into the master branch.

[madmatah]

Hi

Check http://github.com/madmatah/facebook-android-sdk
I swapped out the java.net http library for the apache one.

I didn't use org.apache.http.entity.mime.MultipartEntity because it requires some extra jar libraries (http://bit.ly/c00W2M for more details).

[Maddyy]

i'm not able to download the SDK for android i'm getting the error of the file not found please help me i need it.....

[stephenohair]

I still get the same issue even after swapping out the java.net http library for the apache one. I copied what madmatah did but when my phone is off and there is no data connection my service will fire off a request to facebook via the sdk and my service will indefinitely hang.
No timeouts or anything :(

This bug basically makes the API unsuitable for production use; please fix this.
I'm seeing the API never return simply by switching from cell data to wifi...

[scott2449]

I have a production application using the unaltered api and I also had this problem. I just added conn.setReadTimeout(10000);
conn.setConnectTimeout(10000);
and no more blocking. In later versions of Java, for example the android sdk, this is supported. Has anyone tried? If I have time I'll make mine a bit more api friendly and submit a pull request. I can also include the tests to verify.

[jamesgpearce]

This issue was raised against an previous version of the Facebook SDK for Android.

In 2012, the SDK had a significant rewrite and relaunch, and we are closing issues and pull requests that predate that v3.0 release.

If you are still experiencing this issue, please raise a new issue with repro steps in the supported SDK (currently v3.6). For more information see our Android developer center at https://developers.facebook.com/docs/android.

Many thanks for using the Facebook Platform, and your support of this project.