Pressing 'Back' key does not call onCancel

[facebook]

Pressing 'Back' key does not call onCancel

[yariv]

Sounds like a good idea. We'll look into it.

[zarrabeitia]

I was also stuck with this problem. This patch "solves" it (calls the onCancel when the dialog is dismissed). Any thoughts?

(Edit: I had uploaded an old, broken, patch... Fixed it.)

diff --git a/facebook/src/com/facebook/android/FbDialog.java b/facebook/src/com/facebook/android/FbDialog.java
index 4a1fe93..d6ae982 100644
--- a/facebook/src/com/facebook/android/FbDialog.java
+++ b/facebook/src/com/facebook/android/FbDialog.java
@@ -19,6 +19,7 @@ package com.facebook.android;
 import android.app.Dialog;
 import android.app.ProgressDialog;
 import android.content.Context;
+import android.content.DialogInterface;
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;
@@ -82,6 +83,16 @@ public class FbDialog extends Dialog {
         addContentView(mContent, new FrameLayout.LayoutParams(
                        (int) (dimensions[0] * scale + 0.5f),
                        (int) (dimensions[1] * scale + 0.5f)));
+
+        this.setOnCancelListener(new OnCancelListener()
+        {
+            
+            @Override
+            public void onCancel(DialogInterface dialog)
+            {
+                mListener.onCancel();
+            }
+        });
     }
 
     private void setUpTitle() {

[enthusiastic-nik]

It Causes Crash also when we cancel FB Login dialog and move to another activity...

Uncaught handler: thread main exiting due to uncaught exception
android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@43d3a210 is not valid; is your activity running?
at android.view.ViewRoot.setView(ViewRoot.java:468)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:177)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:91)
at android.view.Window$LocalWindowManager.addView(Window.java:424)
at android.app.Dialog.show(Dialog.java:239)
at com.facebook.android.FbDialog$FbWebViewClient.onPageStarted(FbDialog.java:155)
at android.webkit.CallbackProxy.handleMessage(CallbackProxy.java:234)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:123)
at android.app.ActivityThread.main(ActivityThread.java:4363)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:521)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
at dalvik.system.NativeStart.main(Native Method)

[bgold]

We fixed this a couple months ago. Let me know if you're still seeing any problems.