Giter Site home page Giter Site logo

Comments (4)

chekalsky avatar chekalsky commented on March 29, 2024 2

There are several issues with \Logger:

  • sometimes Composer and our deploy fails because of inavailability of https://packagist.org/packages/apache/log4php
  • \Logger echoes Debug info by default

Could you replace it with Psr\Log please?

Here is the Composer error:

[RuntimeException]
  Failed to execute git clone --no-checkout 'https://git-wip-us.apache.org/repos/asf/logging-log4php.git' '/var/www/.../releases/1482228491/vendor/apache/log4php' && cd '/var/www/.../releases/1482228491/vendor/apache/log4php' && git r
  emote add composer 'https://git-wip-us.apache.org/repos/asf/logging-log4php.git' && git fetch composer
  Cloning into '/var/www/.../releases/1482228491/vendor/apache/log4php'...
  fatal: unable to access 'https://git-wip-us.apache.org/repos/asf/logging-log4php.git/': GnuTLS recv error (-110): The T
  LS connection was non-properly terminated.

from facebook-instant-articles-sdk-php.

scottrigby avatar scottrigby commented on March 29, 2024

Would you guys be willing to have the SDK depend on Psr\Log?

from facebook-instant-articles-sdk-php.

everton-rosario avatar everton-rosario commented on March 29, 2024

Im not sure if we want to add more dependencies to this SDK.
Do you @scottrigby wants to work on this: #21 ?

The #14 and #21 are related and we could work on this as a new feature, adding a Logger abstraction layer and updating Transformer to log events in a separated buffer.

from facebook-instant-articles-sdk-php.

everton-rosario avatar everton-rosario commented on March 29, 2024

PR #304 for this.

from facebook-instant-articles-sdk-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.