Giter Site home page Giter Site logo

Comments (9)

jparise avatar jparise commented on April 20, 2024

We noticed this, too. Our interim solution was just to run the the network activity indicator during the entire login process, but that's not a great user experience either.

If you want to get fancy, you might be able to grab that login dialog's webview delegate and observe the requests as they go by, indicating network activity as appropriate.

Because this is all being handled in the webview, the spinner would ideally be handled by the web content itself.

from facebook-ios-sdk.

yujuan avatar yujuan commented on April 20, 2024

Thanks jparise for the reply. Yes, the best way is handled by the web content. I will file a task on our side to see if we can add that.

from facebook-ios-sdk.

uintaam avatar uintaam commented on April 20, 2024

Also you need to add
[self bringSubviewToFront:_spinner];

after

[self addSubview:_spinner];

or else the spinner wont show.

from facebook-ios-sdk.

kabucey avatar kabucey commented on April 20, 2024

FBDialog.m is missing a webView delegate and the activity indicator should be gray, not white:

  • (void)webViewDidStartLoad:(UIWebView *)webView {
    [_spinner startAnimating];
    }

from facebook-ios-sdk.

cancelself avatar cancelself commented on April 20, 2024

FB Task #390469

from facebook-ios-sdk.

bgold avatar bgold commented on April 20, 2024

Note: there's a pull request for a fix in issue #93

from facebook-ios-sdk.

WilliamDenniss avatar WilliamDenniss commented on April 20, 2024

On slow connections this is really noticeable. Would be nice to have this usability issue resolved.

from facebook-ios-sdk.

GehanD avatar GehanD commented on April 20, 2024

We'd really like this fixed too. Whenever we do app usability tests, this problem is always highlighted; pretty much every user will hit the login button, see that nothing seems to have changed and so hit the login button again, still see no change and then look up looking confused.

It would be greatly appreciated if Facebook could fix this issue asap

from facebook-ios-sdk.

jamesgpearce avatar jamesgpearce commented on April 20, 2024

This issue was raised against a previous version of the Facebook SDK for iOS.

In 2012, the SDK had a significant rewrite and relaunch, and we are closing issues and pull requests that predate that v3.0 release.

If you are still experiencing this issue, please raise a new issue with repro steps in the supported SDK (currently v3.10). For more information, please see our iOS developer center at https://developers.facebook.com/docs/ios/

Many thanks for using the Facebook Platform, and your support of this project.

from facebook-ios-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.