Giter Site home page Giter Site logo

Comments (3)

bigfootjon avatar bigfootjon commented on April 28, 2024 1

Are you asking if Sapling can be a source or destination repo with FBShipIt? It could but it doesn't right now. We detect the repo type based on the presence of a .git or .hg in the root. Since Sapling repos have .sl instead ShipIt will crash as it can't determine the type of repo.

I'll follow up with @bolinfest and figure out how complex it would be to support this. AIUI we're already using Sapling internally but for legacy reasons it continues to use the .hg folder name and hg binary name so our detection method and executing shell commands still works.

from fbshipit.

bolinfest avatar bolinfest commented on April 28, 2024 1

[open source] Sapling does not acknowledge an .hg folder. We did a considerable amount of work to ensure users can have Mercurial and Sapling installed side-by-side such that they don't interfere with one another.

Currently, the presence of an .sl folder means it is a Sapling working copy, but you have to peek inside the .sl/config folder to see what "type" of repository it is. In practice, the repository is inevitably a Git repository because we haven't made the Sapling server "available" (well, the code is on GitHub, but it's a lot of work to set one up...).

If you want to do Git things "sometimes" when using Sapling, you likely have to git clone the repo and do the work over there. Not great, but that's the situation.

Meanwhile, I know evolving Sapling's existing UI into a TUI is something folks on the team are interested in. In general, I think we're more interested in improving the UX of Sapling rather than try to support more and more Git tools within Sapling.

from fbshipit.

bigfootjon avatar bigfootjon commented on April 28, 2024

Thanks!

Ok since OSS Sapling is still just a way to clone an existing git repo I think I'm going to say we're not going to support Sapling repos, yet. When the day comes that Sapling Server is ready for OSS we can re-evaluate then.

from fbshipit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.