can't build, some dependencies don't get found

[facebook]

can't build, some dependencies don't get found

[djwatson]

What does config.log say? Is the CPPFLAGS correct when it is passed to configure?

[doctorseus]

I have the same problem because it seems that the CPPFLAGS and LDFLAGS, set by the deps.sh file, lead to a wrong header/lib location.
configure.ac looks for a headerfile in "double-conversion/double-conversion.h" but CPPFLAGS is set directly to the src folder so it should be "double-conversion.h" only.

Unfortunately I was not able to solve the LDFLAGS problem because I am not really familiar with cpp build tools yet and the content of CPPFLAGS and LDFLAGS had no effect at all for me.
I copied the content of double-conversion/src/ to /usr/local/include/, because this path was searched by default, after that at least the headerfile file check worked.

But the check for ceil method always failed...

(Tested on a clean Ubuntu 12.10 amd64 VM instance)

[doctorseus]

Oky, i have found the problem after 2 days..
I don't know why this commit has been accepted because there is really no chance this works (because the headerfiles are definitly not in "double-conversion", they are in "src"), but if you undo all the changes of this commit, fbthirft finally compiles without any problems.

facebook/folly@56e0ec4#diff-0aeb0bf602d25a066eb2233e06c4a981

[djwatson]

I believe folly is now expecting a new version of double-conversion (that changes the location of headers when installed), we will have to update fbthrift to match

[djwatson]

Closing this, both folly and thrift now expect a system double-conversion library, such as libdouble-conversion-dev from ubuntu 14.04