Comments (5)
We're now using a newer version. Please have a look and let us know how it works!
from hermes.
The current hash was chosen to align with our platform, and like for you it's not trivial to update it independently. How many of these issues are there, and how systematic are they?
from hermes.
This was the main one:
- : public ilist_default_traits<::hermes::ESTree::Node> {
+ : public ilist_node_traits<::hermes::ESTree::Node> {
If it's just a few one-liners like this, maybe we can wrap them in #if __llvm__ >= N
blocks?
It's also possible that some of them actually still work with the old version. Is there an ETA for a CI setup so I could experiment with such changes easily?
from hermes.
I don't see any issues with wrapping them like this, or wrapping typedef'ing them if there's many of the same type.
External CI is probably a while out still, but this is a good reason to bump its priority.
from hermes.
@matthargett Would you be able to send these required changes as a PR? I'm looking into whether we can be early adopters of the latest version of the FB platform with an LLVM version from October, and having the source changes ready would make that an easier sell
from hermes.
Related Issues (20)
- Segfault in production Android app - facebook::hermes::debugger::EventObserver::breakpointResolved HOT 4
- Guide about benmarking JavaScript perf on Hermes HOT 1
- Support FinalizationRegistry in Hermes HOT 2
- Intentional fallthrough? HOT 4
- RangeError: Maximum callstack size exceeded with many modules in single bundle HOT 20
- "HBC version" should be reflected in the documentation or the file name HOT 1
- In iOS, is it possible to compile Hermes as a static library instead of a dynamic library? HOT 1
- Wrong bytecode version with hbcdump HOT 1
- Bug in scoped function promotion (non-strict mode) HOT 3
- Problems loading emscripten compiled js file in Hermes. Works on JSC/V8. HOT 6
- Invalid Source map HOT 1
- [hermes-parser] Support Import Attributes HOT 1
- When I CrossCompilation build for android, I got the error, the branch is 'rn/0.74-stable' HOT 3
- SyntaxError: Invalid RegExp: Invalid escape, js engine: hermes HOT 3
- Failed to build CLI on Linux HOT 2
- Intl.PluralRules support
- Fail to build android dynamic lib 'libhermes.so' in branch 'origin/static_h' HOT 4
- Intl.NumberFormat signDisplay option displays odd behaviour HOT 1
- instanceof on host objects HOT 16
- Symbol.hasInstance is not used in instanceof lookup HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hermes.