Hermes relies on deprecated/removed things in newer versions of LLVM

[facebook]

Hermes relies on deprecated/removed things in newer versions of LLVM

[willholen]

We're now using a newer version. Please have a look and let us know how it works!

[willholen]

The current hash was chosen to align with our platform, and like for you it's not trivial to update it independently. How many of these issues are there, and how systematic are they?

[matthargett]

This was the main one:

-    : public ilist_default_traits<::hermes::ESTree::Node> {
+    : public ilist_node_traits<::hermes::ESTree::Node> {

If it's just a few one-liners like this, maybe we can wrap them in #if __llvm__ >= N blocks?
It's also possible that some of them actually still work with the old version. Is there an ETA for a CI setup so I could experiment with such changes easily?

[willholen]

I don't see any issues with wrapping them like this, or wrapping typedef'ing them if there's many of the same type.

External CI is probably a while out still, but this is a good reason to bump its priority.

[willholen]

@matthargett Would you be able to send these required changes as a PR? I'm looking into whether we can be early adopters of the latest version of the FB platform with an LLVM version from October, and having the source changes ready would make that an easier sell