strict mode: Spurious 'Too many arguments' errors

[facebook]

strict mode: Spurious 'Too many arguments' errors

[dkao1978]

I'm running into this as well with python 3.6.5, pyre-check 0.0.7, using a stubs file.

class ProductQuerySet(models.query.QuerySet):
...

ProductQuerySet(self.model, using=self._db)

Stubs file:

from typing import Any

class QuerySet:
    def __init__(self, model: Any=None, query: Any=None, using: Any=None, hints: Any=None): ...

    def filter(self, *args: Any, **kwargs: Any) -> self: ...

Error message:

models.py:59:11 Too many arguments [19]: Call `.models.ProductQuerySet.__init__` expects 1 positional argument, 3 were provided.

def filter(...)... in the stubs file is working correctly.

[dark]

Thanks for the report!
I will reproduce this issue locally and let you know what I find.

[dark]

Turns out these errors reflect two different issues:

• we are not looking at __new__ now (pathlib.Path uses it)
• we are not suppressing arity errors in constructors we cannot resolve.

I will edit this task to track the second issue specifically.

[sinancepel]

Pyre is properly handling __new__ in this case now, and doesn't error for either case.