Comments (8)
Oh haha. RTFM. It's actually pretty simple:
- (void)loadMesh:(NSString *)path {
RCT_EXPORT();
dispatch_async(dispatch_get_main_queue(), ^{
node.mesh = [REMeshCache meshNamed:path];
});
}
That works!
from react-native.
If you are bored, would be awesome to compile this into some sort of docs :)
from react-native.
If you are bored, would be awesome to compile this into some sort of docs :)
I almost filed an issue about that, actually! I was going to ask if there's a place you want us to contribute to docs. I can certainly write done a bunch of small stuff I've learned. Where would you like it, and what format?
from react-native.
We're going to have official docs before we open this repo to everyone. They'll be in the docs folder in markdown, the same way React is. If you can start writing them in markdown and in the docs folder with whatever you think is useful for people, that would be awesome!
https://github.com/facebook/react/tree/master/docs/docs
from react-native.
Looks like this is a very common pattern - native modules that run on main thread. Maybe we could do something like:
- (void)loadMesh:(NSString *)path {
RCT_EXPORT_ON_MAIN_THREAD();
node.mesh = [REMeshCache meshNamed:path];
}
@a2 / @nicklockwood - any thoughts?
from react-native.
The JS bridge is meant to be asynchronous and therefore runs off the main thread. I personally think that if something should happen on a specific thread/queue, it is the caller's responsibility. Apple's documentation often says that callbacks can happen on private threads/queues and that you should dispatch if necessary.
from react-native.
@a2 great answer, totally makes sense!
from react-native.
Whilst @a2 is quite correct, I wonder if it might make sense to change the thread that we call back to modules on to main.
We don't call module methods on the JS thread, we actually call them on the shadow thread, which is a seperate thread used by the RCTUIManager to do layout calculations.
But other than the UIManager, the vast majority of modules either don't care what thread they run on, or would prefer to run their methods on the main thread. Perhaps then, the bridge should call back to main, and the UIManager can dispatch to the shadow thread?
It would save having to dispatch_async inside every single module's methods for the sake of catering to the requirements of one specific module.
from react-native.
Related Issues (20)
- IOS build takes too long and never finishes for 0.75.2 version HOT 8
- react native bundle hangs after adding product flavour config to build.gradle HOT 3
- Using absolute positioning, when the parent element has padding, the width height of the current element is incorrectly laid out using a percentage layout HOT 12
- Android Crash: SIGSEGV 0x0000000000000000 - libc.so | Crashed: null pointer dereference HOT 5
- Google Api Error: Invalid request - Your app declares support for 'riscv64' architecture, but the following libraries are missing HOT 5
- ReactNative 0.68.0 -> 0.73.0 : much more slower on android release builds HOT 7
- ReactContext is getting null value in Android native project. HOT 3
- Extra line wrap on some Android devices on some combinations of lineHeight, letterSpacing and other related properties
- Just a test bug for React Native Dev Tools HOT 2
- [0.75.3] Build failing with: "RNGP - Autolinking: Could not find project.android.packageName in react-native config output!" HOT 13
- reactnative.dev SITE IS DOWN. IT HAS BEEN DOWN FOR MORE THAN 3 HOURS HOT 6
- AlignItems may sometimes become invalid on Android HOT 4
- I can't open the new architecture according to the steps on the official website, on ios and android platforms HOT 6
- Another DevTools Test Issue HOT 2
- Test issue HOT 2
- In IOS TextInput does not update style if copy and pasted string is bigger then maxLength HOT 8
- [id: 'com.facebook.react.settings'] > java.io.UncheckedIOException: HOT 3
- Run-android command is stuck without giving any output HOT 4
- Build failed on android with "Task : android:buildCMakeDebug[arm64-v8a] FAILED" HOT 8
- [Android] Headless Crash `Tried to finish non-existent task with id` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native.