Comments (13)
@cipolleschi can you have a look when you have some time? thanks 🙏
from react-native.
Shouldn't the header search path link to the headers in the pods?
nope, because with frameworks, the items that are copied to the bundle and used for linking are the content of the .framework
folder.
Have you been able to make the audio manager build by that change ?
Unfortunately not, once I saw that the setup was not standard and the error was different, I stopped.
I think we should first understand why we are seeing two different errors.
Unfortunatly I have a lots of them with the current setup, so it's not something I was plan to do immediatly, but I'll definitely consider it
😞 But I understand. Working with legacy projects is tough. I'm going to be on PTO next week, but I plan to resume the work on this when I'm back.
from react-native.
thanks! It seems working now (at least this building phase). I'll late you know if I have any other issue while migrating to the latest version.
I'm gonna close the issue
from react-native.
I also checked and it's breaking starting from 0.74.0
from react-native.
Also getting this issue :'(
from react-native.
Looking into it.
We probably make a mistake in configuring the RCTDeprecation podspec.
from react-native.
@fbp93 I tried the app and the main target builds fine with static libraries and static frameworks.
AudioManager fails, but it fails because React/RCTBridgeModule.h' file not found
, not RCTDeprecation
not found
I think that the problem is in the header search paths. If you look at the search paths for the main project, they look like this:
The header search paths of the AudioManager looks like this:
The structure of React-Core on disk is like this:
And, as you can see, there is no folder called Public
after Headers.
This type of setup, anyway, is not something we recommend: it would be better to create a proper pod for an external library, to benefit from all the automations we are building for autolinking.
That said, @fbp93 and @max-quirk, if you can provide a reproducer where I can see the RCTDeprecation.h file not found happen
, I'll be glad to dig into it more closely!
from react-native.
And, as you can see, there is no folder called Public after Headers.
@cipolleschi Shouldn't the header search path link to the headers in the pods? Because there I see the public folder. Have you been able to make the audio manager build by that change ? 🤔
This type of setup, anyway, is not something we recommend: it would be better to create a proper pod for an external library, to benefit from all the automations we are building for autolinking.
Unfortunatly I have a lots of them with the current setup, so it's not something I was plan to do immediatly, but I'll definitely consider it
from react-native.
nope, because with frameworks, the items that are copied to the bundle and used for linking are the content of the .framework folder.
the weird thing is that the same setup was working fine with the previous react and even if I try to remove the public it's not working anyway 🤔
Unfortunately not, once I saw that the setup was not standard and the error was different, I stopped.
I think we should first understand why we are seeing two different errors.
Actually it seems that sometimes I get your same error and sometimes the RCTDeprecation one, so I think it's kind of related. Probably if we are able to make it build we may fix both or understand more 🤔
from react-native.
@fbp93 any news on this?
In 0.73, we didn't have the RCTDeprecation
module, so that's probably why it was working.
from react-native.
@fbp93 I investigated this a little bit more.
First of all, my bad. I was trying to build with use_frameworks, but after reading the issue again, I can see that that was not the case.
Without frameworks, the search path you were using ($(SRCROOT)/../../ios/Pods/Headers/Public/React-Core
) is correct.
I added another search path there: $(SRCROOT)/../../ios/Pods/Headers/Public
.
and after that, it builds correctly.
The problem is that the Audio Manager was not finding the header in the available search paths.
Starting from Public
, the RCTDeprecation.h
header is in the path RCTDeprecation/RCTDeprecation.h
that is exactly the same import you have in the file.
This is not a standard and officially supported setup, so I don't think we can/should modify core to automate this.
I hope this is enough to understand how these search paths work and to fix them forward for all the modules.
from react-native.
@fbp93 How did you resolve the issue?
from react-native.
@fbp93 How did you resolve the issue?
I changed the header path as suggested in the above message
from react-native.
Related Issues (20)
- [iOS] Hash Generated Using Broken Cryptography API (SHA1) HOT 3
- Failed to generate podfile.lock HOT 4
- RN Alert button sometimes renders in the upper-left corner of the screen (iOS)
- [0.76.0 (nightly)] `react-native` command fails silently HOT 1
- Accessibility in android- With talkback elements are not clickable while on a screen from stack navigator. HOT 6
- PermissionsModule$1.invoke java.lang.IllegalArgumentException - Unknown permission: android.permission.POST_NOTIFICATIONS HOT 3
- React Native app works fine on ios but Axios network request in android not working HOT 6
- Modal is getting truncated when rendering at bottom on Android 15 HOT 4
- Dimensions.addEventListener not firing react native 0.74.3 HOT 6
- Inspector Tools issue when view are transformed in Fabric
- React Native Android fails with Desugaring enabled HOT 6
- The onChangeText and onChange events on a TextInput fire twice on Android HOT 8
- Android - Composer - Previous text is cut off after creating next line HOT 5
- [0.75.0-rc.5] Android crashes at app launch on New Architecture HOT 2
- Text inline Image in RTL layout, image position will be offset HOT 7
- Unhandled JS Exception: Invalid regular expression: HOT 6
- SIGSEGV Crashed: null pointer dereference HOT 7
- Sticky views have visual glitches while scrolling in ScrollView HOT 1
- targetSdkVersion 33 to 34 app crash HOT 9
- Error: package com.facebook.react.modules.storage does not exist import com.facebook.react.modules.storage HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native.