[Web Socket][Android] Sec-WebSocket-Protocol header should have a space after the comma

[justinmann]

[Web Socket][Android] Sec-WebSocket-Protocol header should have a space after the comma

[github-actions]

⚠️

Newer Version of React Native is Available!

ℹ️

You are on a supported minor version, but it looks like there's a newer patch available - 0.73.8. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

[github-actions]

⚠️	Missing Reproducible Example
ℹ️	We could not detect a reproducible example in your issue report. Please provide either: If your bug is UI related: a Snack If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

[cortinico]

I am not sure this is violation of the RFC: rfc-editor.org/rfc/rfc6455

Can you point specifically to what in the RFC we're violating?

[justinmann]

As I stated above, I am not sure this is an RFC violation, it is just does not match the convention used by other WebSocket client libraries (including the iOS library for React-Native).

I believe this is relevant RFC:
https://www.rfc-editor.org/rfc/rfc2616#section-4.2
"Multiple message-header fields with the same field-name MAY be
present in a message if and only if the entire field-value for that
header field is defined as a comma-separated list [i.e., #(values)].
It MUST be possible to combine the multiple header fields into one
"field-name: field-value" pair, without changing the semantics of the
message, by appending each subsequent field-value to the first, each
separated by a comma."

The RFC seems to be more of a suggestion and it just says to use a "," but makes no mention of adding a space ", ".

[cortinico]

The RFC seems to be more of a suggestion and it just says to use a "," but makes no mention of adding a space ", ".

Yeah this is a bit of a weak statement. If you could provide more evidence that adding a space after the , is breaking the specs we could potentially change it.