Giter Site home page Giter Site logo

Comments (12)

sophiebits avatar sophiebits commented on March 29, 2024

(Inline elements are allowed inside a <p>; other <p> tags and block-level elements are not.)

from react.

petehunt avatar petehunt commented on March 29, 2024

√ react has no idea though

from react.

sophiebits avatar sophiebits commented on March 29, 2024

React also does badly in this case with things like text nodes inside <table> elements (outside of a cell). It ends up throwing the error:

Uncaught Error: The framework has attempted to either insert zero or multiple markup roots into a single location when it should not. This is a serious error - a fault of the framework - please report immediately.

which is confusing and doesn't help anyone. This happens because in dangerouslyReplaceNodeWithMarkup, setting innerHTML to <table>oops!</table> gives two child nodes: oops! and <table></table>.

Demo: http://jsfiddle.net/spicyj/ENxaB/

We should work on better messaging here.

from react.

tomocchino avatar tomocchino commented on March 29, 2024

👍 to better error messages.

I think this could get into dangerous territory quickly, though @petehunt. Pretty soon we'll want full-on child validation (like we have in XHP).

from react.

sophiebits avatar sophiebits commented on March 29, 2024

React also gets confused by <tbody>. :(

When you click on the table at http://jsfiddle.net/Gzm5N/1/, it should produce output of:

Row 0
Row 1
Row 2
...
Row 2
Row 1
Row 0

but doesn't because

dangerouslyInsertMarkupAt(table, "<tr>...</tr>", i)

inserts a <tbody><tr>...</tr></tbody> instead. :(

jQuery has a hardcoded list of places where it does stuff differently https://github.com/jquery/jquery/blob/master/src/manipulation.js#L12-L30 so maybe we need the same.

from react.

sophiebits avatar sophiebits commented on March 29, 2024

(Tables still broken in React 0.4: http://jsfiddle.net/spicyj/Gzm5N/2/)

from react.

brianr avatar brianr commented on March 29, 2024

@spicyj The tables issue appears to be fixed, at least partially, in master. See this jsfiddle: http://jsfiddle.net/6pBnK/2/

It looks like commit fixed it: adffa9b

There's still some weirdness because the original <tr>s are inside a <tbody> and the rest are directly in the <table>, but the order is correct.

from react.

xixixao avatar xixixao commented on March 29, 2024

+1, I had non-dangerous looking:

render: ->
  _div {},
    _p _h2 'Source'
    _p {},
      _textarea cols: 152, rows: 6, onChange: @handleChange
    _p {},
      _button onClick: @translate, 'Traslate'
      _button onClick: @run, 'Run'
    _p _h2 'Translation'
    _p {},
      _pre @state.result

(blindly copied from some old html). Somehow baking @spicyj 's comment above into the error messages would be useful.

from react.

xixixao avatar xixixao commented on March 29, 2024

Just ran into the table case (oh boy that's hard to debug!), simply by not using tbody (penalty for learning HTML before people started actually using tbody). Looking forward to 735.

from react.

syranide avatar syranide commented on March 29, 2024

Related #1987

from react.

zpao avatar zpao commented on March 29, 2024

I'm just going to close this out. We left it open a long time but we haven't made any progress apart from improved error messages. It's still a hard problem to solve in a reasonable way, so I'm calling it off.

from react.

syranide avatar syranide commented on March 29, 2024

@zpao Like I mentioned in my "no data-reactid"-PR, it is possible to catch this immediately as it occurs really quite cheaply (so it's a good fit for DEV at the very least) and it's just a few lines of code as well. Considering that PROD-behavior would stay lenient, the DEV/PROD inconsistency shouldn't be an issue either.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.