Add TextureView/SurfaceView support

[facebook]

Add TextureView/SurfaceView support

[Guardiola31337]

Hey 👋 @tdrhq

Revisiting this one, the solution you suggested wasn't feasible because subclasses of TextureView cannot do their own rendering with the Canvas object so I opted to create both Bitmaps and do a simple merge.
How does that sound? Do you see any drawbacks?

It still remains adding a way to get a Bitmap from SurfaceViews, but at least TextureViews are unblocked.

Happy to know what you think about #71

Thanks a lot!

[tdrhq]

So, I'm not a TextureView/SurfaceView expert, but based on your description you seem to be on the right path, and I'd love to have the eventual fix pulled in.

In this particular case, it looks like the View is drawing over your TextureView, probably because you have a view behind the TextureView which in production will be drawn first, but in your code is drawn after the TextureView.. something like this

• BackgroundView
  • TitleBar
  • TextureView
  • MapboxImage

The solution will be to draw the TextureView while drawing the rest of the views, which might be tricky (since it's the draw() that dispatches the draw() for the children). Perhaps a ScreenshotSafeTextureView that detects if it's running in a screenshot test and in which case just do the logic you showed inside of its onDraw() method?