Comments (4)
Grrr
Expected {smallWidth: 34.671875, smallHeight: 18, bigWidth: 172.421875, bigHeight: 36, bigMinWidth: 100.453125}
to equal {smallWidth: 34.671875, smallHeight: 16, bigWidth: 172.421875, bigHeight: 32, bigMinWidth: 100.453125}, 'Looks like browser has updated its text measurements functions. You need to update `preDefinedTextSizes` in Layout-test-utils.js'.
looks like smallHeight and bigHeight changed from 18 to 16 and 36 to 32. Can you make sure you aren't zoomed by chance?
from yoga.
Zoom is at 100%. If I zoom in or out, a lot more tests fail.
I have a retina display, might that be related?
from yoga.
I am getting the exact same errors. I've tried on both a retina and non-retina display. Assuming that the error message given is correct. It looks like chrome has changed their text measurements functions and if you look at the other two tests that are failing, they appear to be off by exactly that amount.
I've put in a pull request for this #35.
from yoga.
@jimmyhmiller thanks, it fixed it :)
from yoga.
Related Issues (20)
- Absolute children do not respect padding of parent HOT 1
- [!] An error occurred while processing the post-install hook of the Podfile. HOT 1
- Can run on Mac Catalyst, but cannot be archive on Mac Catalyst HOT 10
- wasm-sync file index error in package.json HOT 2
- [website-next] Replace Yoga Node Editor with `@theme/CodeBlock` HOT 8
- Add `YGNodeStyleSet<Property>CSS` for CSS values as strings HOT 1
- Add `yoga::Style::resolve()` for ahead-of-time computed whole style HOT 2
- Try using explicit modulemap in CocoaPods build HOT 1
- Typo in recent module.modulemap change that breaks Swift PM-based builds HOT 1
- [JS] Move from embind to manual bindings HOT 1
- Flex shorthand in UseWebDefaults should set basis to 0 instead of auto HOT 3
- React Native iOS build failed HOT 1
- top position is wrong when previous item's height is 0.5, on 3x scale screen HOT 1
- API proposal to get the computed measure size of a node HOT 9
- Proposal: Integrate with google/oss-fuzz for continuous fuzz testing? HOT 8
- Can a Yoga Node have multiple owners? HOT 3
- [JS] Reduce WASM call overhead HOT 6
- Add App Privacy Manifest? HOT 1
- `flexBasis` doesn't recalculate when rotating the screen HOT 1
- __dirname is not defined in ES module scope HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yoga.