Giter Site home page Giter Site logo

Comments (4)

vjeux avatar vjeux commented on May 4, 2024

Grrr

Expected {smallWidth: 34.671875, smallHeight: 18, bigWidth: 172.421875, bigHeight: 36, bigMinWidth: 100.453125} 
to equal {smallWidth: 34.671875, smallHeight: 16, bigWidth: 172.421875, bigHeight: 32, bigMinWidth: 100.453125}, 'Looks like browser has updated its text measurements functions. You need to update `preDefinedTextSizes` in Layout-test-utils.js'.

looks like smallHeight and bigHeight changed from 18 to 16 and 36 to 32. Can you make sure you aren't zoomed by chance?

from yoga.

fabb avatar fabb commented on May 4, 2024

Zoom is at 100%. If I zoom in or out, a lot more tests fail.
I have a retina display, might that be related?

from yoga.

jimmyhmiller avatar jimmyhmiller commented on May 4, 2024

I am getting the exact same errors. I've tried on both a retina and non-retina display. Assuming that the error message given is correct. It looks like chrome has changed their text measurements functions and if you look at the other two tests that are failing, they appear to be off by exactly that amount.

I've put in a pull request for this #35.

from yoga.

vjeux avatar vjeux commented on May 4, 2024

@jimmyhmiller thanks, it fixed it :)

from yoga.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.