hash_set deprecated

[facebookarchive]

hash_set deprecated

[Yangqing]

T_T glog :(

I guess we can put an -W message to suppress it? What specific deprecation warning are we getting?

[Yangqing]

Actually, it seems that glog already supports unordered_set instead of hash_set:

https://github.com/google/glog/blob/0472b91c5defdf90cff7292e3bf7bd86770a9a0a/src/glog/stl_logging.h.in#L41

Maybe this is due to the ubuntu apt-get package not properly compiled.

[slayton58]

We could also move glog to a submodule and compile it ourselves to solve this - slightly heavy-handed though...

[Yangqing]

Would you guys be fine with tolerating the warning message? :)

[pooyadavoodi]

I would prefer to properly get rid of the warning messages only because they are so many (hundreds) and I always ignore them all. This way we can notice new warning messages which could save us from bugs :)
http://www.cprogramming.com/tutorial/compiler_warnings.html

[thatguymike]

We can silence the warning for now.

[Yangqing]

@thatguymike Mike - what is the build environment you use? I cannot repro on my 16.04 so I probably need a VM.

[thatguymike]

14.04 fully updated

[Yangqing]

Should have been fixed in #172 - feel free to reopen this @thatguymike :)