libedit/readline compatibility

[facebookarchive]

libedit/readline compatibility

[wjywbs]

This is my patch to build it:

diff --git a/cmake/readline.cmake b/cmake/readline.cmake
index 353dab0..4167d02 100644
--- a/cmake/readline.cmake
+++ b/cmake/readline.cmake
@@ -157,7 +157,7 @@ MACRO (FIND_SYSTEM_LIBEDIT name)
     #include <readline/readline.h>
     int main(int argc, char **argv)
     {
-      char res= *(*rl_completion_entry_function)(0,0);
+      char res= (*rl_completion_entry_function)(0,0);
       completion_matches(0,0);
     }"
     ${name}_USE_LIBEDIT_INTERFACE)

Remove the * outside of the ().

[wjywbs]

@denji could you try the new build instructions published by @jwatzman? Specifically,

    -DCMAKE_C_FLAGS="-I$(brew --prefix readline)/include -L$(brew --prefix readline)/lib" \
    -DCMAKE_CXX_FLAGS="-I$(brew --prefix readline)/include -L$(brew --prefix readline)/lib" \

The settings above fixed the build for me.

https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.10

[denji]

@wjywbs your changes do not affect the build, homebrew priority uses the path /usr/local/{include,lib} in cmake building these folders linked readline too.

• https://github.com/Homebrew/homebrew/blob/5596e28/Library/Homebrew/extend/ENV/super.rb#L54-L57
• https://github.com/Homebrew/homebrew/blob/5a2292f/Library/Homebrew/build.rb#L99-L101

The problem in cmake/readline.cmake, it does not support tests for latest readline.

[jwatzman]

@wjywbs your changes do not affect the build, homebrew priority uses the path /usr/local/{include,lib} in cmake building these folders linked readline too.

Something about that superenv stuff either isn't working as expected, or isn't making it thru HHVM into the webscalesql subproject that HHVM builds. Those two lines definitely fixed this issue for me as well, that's why I added them :)

The problem in cmake/readline.cmake, it does not support tests for latest readline.

I thought this was due to BSD's readline being weird, but I'm not totally sure on this one.

[cruisercoder]

Trying to figure out how to build on 10.11.4 with hints from above and I get the errors below. Any ideas?

cd webscalesql/build
cmake -DCMAKE_C_FLAGS="-I$(brew --prefix readline)/include -L$(brew --prefix readline)/lib" -DCMAKE_CXX_FLAGS="-I$(brew --prefix readline)/include -L$(brew --prefix readline)/lib" ..

...
CMake Error at cmake/readline.cmake:183 (MESSAGE):
Cannot use libreadline!
Call Stack (most recent call first):
cmake/readline.cmake:194 (FIND_SYSTEM_LIBEDIT)
CMakeLists.txt:397 (MYSQL_CHECK_READLINE)