SocketRocket does not support the Sec-WebSocket-Protocol header

[facebookincubator]

SocketRocket does not support the Sec-WebSocket-Protocol header

[mikelikespie]

I'm not sure how this should be exposed. For now, one can

NSMutableURLRequest *r = [[NSMutableURLRequest alloc] initWithURL:@"ws://example.com/bar"];
[r setValue:@"chat, superchat" forHTTPHeaderField:@"Sec-WebSocket-Protocol"]
// Use r when initializing socket

[mikelikespie]

@matzew Going to close this issue for now (just doing a bit of cleanup). If you're having trouble with manipulating the NSURLRequest, please let me know.

[matzew]

@mikelikespie usually the protocols is applied in the constructor (see http://dev.w3.org/html5/websockets/#the-websocket-interface )

Also similar code (java based)
https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerFactory.java#L42

and:
https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java#L71

[mikelikespie]

Thanks for pointing that out.

I am considering adding just a second constructor that takes a URL and list of protocols. Would this be sufficient?

[matzew]

Hey,

see:

matzew@5ed9fe6

that's good enough; I opened a pull request for that;

Cheers!
Matthias

[mikelikespie]

@matzew Thanks for the pull request. I fixed it slightly differently in ce4fb27 (also, your pull request has a change for the origin stuff too)

Thanks again for the reporting.
-Mike

[sashakid]

Hi, is that all about error Error Domain=SRWebSocketErrorDomain Code=2133 "Invalid Sec-WebSocket-Accept response." UserInfo={NSLocalizedDescription=Invalid Sec-WebSocket-Accept response.}?