[BUG] method = 'rake' return AttributeError

[facebookresearch]

[BUG] method = 'rake' return AttributeError

[talgalili]

Hey @geniusjenny

Thanks for the bug report!

Could you please try to run the code from the rake tutorial:
https://import-balance.org/docs/tutorials/quickstart_rake/
And see if you can reproduce the code from it?

What would help me is a fully self-contained reproducible example that I could run in my env to reproduce the error - that would allow me to more easily iterate to get a solution.

Thanks upfront!

[geniusjenny]

Thanks for the replies!
For the sample code it runs smoothly with no error.

[talgalili]

Thanks for checking @geniusjenny
Any way you could play around and try to find a way to reproduce the issue?
I suggest you look at the
sample.df.info()
And look at the data types, and maybe the hint could be there.

Once you could find a way to reproduce the issue, I'd be able to work on it.
WDYT?

[geniusjenny]

Hi talgalili, I tried to reproduce the issue but couldn't. I tried using two numerical features ['income', 'happiness'] similar with what I have for my dataset, and the code runs smoothly.
I attached the sample data here for you to reproduce the issue. Sorry that I couldn't be more helpful.

Thank you so much.
sample_test2.csv
target_test2.csv
code:

s2= pd.read_csv('sample_test2.csv',index_col=0)
t2= pd.read_csv('target_test2.csv',index_col=0)
sample = Sample.from_frame(s2)
target = Sample.from_frame(t2)
sample_with_target = sample.set_target(target)
adjusted_ads_weight1 = sample_with_target.adjust(method = "rake") 

[talgalili]

Thanks @geniusjenny

Just to double check, could you please paste the full output of you running the above code?
And please also include the output of:
sample.df.info()
target.df.info()

Thanks!

[geniusjenny]

Sure!
Full output:

df.info:

[talgalili]

Thanks! Could you please try to bucket the variables and try again? I think rake should be defined on categorical variables and not numeric ones (how to correct it woth a default is a good question - but I'd like to double check that this is indeed the issue)

…

On Wed, 6 Mar 2024, 17:42 Han Wang, ***@***.***> wrote: Sure! Full output: image.8.png (view on web) <https://github.com/facebookresearch/balance/assets/55514836/062abe70-d576-4c27-a7d4-406df8087a32> image.4.png (view on web) <https://github.com/facebookresearch/balance/assets/55514836/5aeb9839-d033-495f-a1c4-a6647c96d031> image.5.png (view on web) <https://github.com/facebookresearch/balance/assets/55514836/ea7096ab-95fd-4b1d-8dfb-84c2e042cb91> df.info: image.9.png (view on web) <https://github.com/facebookresearch/balance/assets/55514836/b0063461-b472-4b75-b4ac-31ac8b75e3bc> — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBWPPETVDXACP5WN35TYW42QHAVCNFSM6AAAAABEGM4J7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGE3DQNBZGY> . You are receiving this because you commented.Message ID: ***@***.***>

[geniusjenny]

Hi talgalili,
I just tried binning the numerical variables to categorical variables, but still the code returns the same error. While method='cbps' and method = 'ipw' run smoothly.

Here are the code and df.info:

ERROR:

[talgalili]

Thanks @geniusjenny
Interesting!
Could you please change the object type of the bucketed variables from 'categorical' to 'object'? And let me know if this resolve the error you get?

[geniusjenny]

I also tried that. Still getting the same error.

[geniusjenny]

I think I may find the issue.
Some of the bin that appears in the sample has never appeared in the target, causing this error.
Once I add the sample to the target, the bug disappear.
I suggest the code take this edge case in consideration as well!

t2=pd.concat([s2,t2])
t2.reset_index(inplace=True)
t2['id']=t2.index.astype('str')

[talgalili]

Great catch - thanks a bunch @geniusjenny !

O.k., I'll leave this issue open - and we'll get to add a proper exception in the future.

Thanks again.

[geniusjenny]

Thank you!