--stop-on-error stop-on-failure implementation

[facile-it]

--stop-on-error stop-on-failure implementation

[Jean85]

Since we have parsers for each of those kind of test outcome, we could give the responsability of dispatching events to those parsers. Then, the runner should be configured at runtime to stop execution if a requested kind of event is dispatched. Some of the refactoring inside #11 should help on this matter, since I made the container preparation later, there.

Do you think that those options should be also carried over to the single PHPUnit processes? (see #57)

[ranpafin]

@Jean85

Since we have parsers for each of those kind of test outcome, we could give the responsability of dispatching events to those parsers. Then, the runner should be configured at runtime to stop execution if a requested kind of event is dispatched. Some of the refactoring inside #11 should help on this matter, since I made the container preparation later, there.

Surely the right direction, we should delay this a little bit, Util the #11 is ready!
I would add that the runner could listen to a "shutdown" (or terminate/complete etc..) event.
While the parsers could fire their own context-based events (failure_detected, error_detected..) the shoutdown notification should be prompted by another module of the system in order to keep the parser agnostic to any of this logic.

Do you think that those options should be also carried over to the single PHPUnit processes? (see #57)

If the option is handled in the global context pushing it down to the childs processes won't change much. It could turn out to be useful if the single test execution is expensive. In that case the single process will exit faster. In any case, considering that the cost of passing along the option to the childs is very little i think it should be done.

[Jean85]

Since I merged #58, that comes practically for free!

Il ven 11 nov 2016, 17:13 Francesco Panina [email protected] ha
scritto:

@Jean85 https://github.com/Jean85

Since we have parsers for each of those kind of test outcome, we could
give the responsability of dispatching events to those parsers. Then, the
runner should be configured at runtime to stop execution if a requested
kind of event is dispatched. Some of the refactoring inside #11
#11 should help on this
matter, since I made the container preparation later, there.

Surely the right direction, we should delay this a little bit, Util the
#11 #11 is ready!
I would add that the runner could listen to a "shutdown" (or
terminate/complete etc..) event.
While the parsers could fire their own context-based events
(failure_detected, error_detected..) the shoutdown notification should be
prompted by another module of the system in order to keep the parser
agnostic to any of this logic.

Do you think that those options should be also carried over to the single
PHPUnit processes? (see #57
#57)

If the option is handled in the global context pushing it down to the
childs processes won't change much. It could turn out to be useful if the
single test execution is expensive. In that case the single process will
exit faster. In any case, considering that the cost of passing along the
option to the childs is very little i think it should be done.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#58 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGaxBFk-p7hghsYzB26oluj9j1O-gh2cks5q9JQNgaJpZM4Kv0os
.

[Jean85]

Closing as superseded by #198