Abstract test cases should not be executed

[facile-it]

Abstract test cases should not be executed

[dxops]

Just rename them to *TestCase

[Jean85]

I've already encountered this issue.
Right now, the main issue is that I don't read inside the test files like PHPUnit does, so I'm not able to discern abstract from non-abstract classes. I solved this issue before with a naming convention, making abstract classes not caught up by the prefix/suffix settings of PHPUnit.

I'm open to suggestions; if anyone has an approach to avoid those problems, I'm all ears!

[dxops]

We follow Symfony convention too.

Prefix abstract classes with Abstract. Please note some early Symfony classes do not follow this convention and have not been renamed for backward compatibility reasons. However all new abstract classes must follow this naming convention;

I think it's ok to make this prefix default one

[Jean85]

Then, you can hotfix this changing the XML config, blacklisting the tests that have this prefix, right?
I'm not sure if blacklisting by default in Paraunit is a good idea, I can't assume that that convention is always used; as an example, I have a AbstractEntityTest.php in a project of mine, but the test is not abstract, the tested class is (well, the tested features, through child classes).

[dxops]

Ok, but let's leave this issue open, just not to forget to skip abstract test suites somehow (check using AST maybe?)

[Jean85]

I don't know how to do that, and I'm from mobile so my Google-fu is somewhat limited right now..but definitely yes, I don't want to close this issue.

I would like to remove abstract test classes from the execution queue beforehand, but only if that is possible without impacting too much on performances. Otherwise, I would prefer an other approach, just catching those cases afterwards, while analyzing the test outcome. I need to investigate what outcome I get via logs and exit code when I wrongly try to execute PHPUnit over an abstract test class.

[yisraeldov]

@Jean85

This could just take avanage of phpunit's parsing.

phpunit --list-tests

That will give you all the runable tests.

[Jean85]

Thanks @yisraeldov but unfortunately that outputs the FQCN, which is no use for Paraunit: I cannot launch tests from the class name, I need the file name...

[dxops]

@Jean85 https://blog.wyrihaximus.net/2016/10/utilizing-composers-classloader-to-get-a-class-contents/

[Jean85]

That unfortunately iwouldn't always work. PHPUnit works event with classes that have broken the PSR-0/4 autoloader, or even files that do not contains classes, like the PHPT tests. That would not work with that approach.

OTOH, it would be possible to parse that output anyway and act on it, but I fear that it would be slow...